Create and specify custom color maps #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of the quest for transparent windows/colors
MadLittleMods
commented
Sep 15, 2023
| writeIntNative(u32, buf + 8, args.window_id); | ||
| writeIntNative(u32, buf + 12, args.visual_id); | ||
| } | ||
| }; |
There was a problem hiding this comment.
X11 protocol docs: https://www.x.org/releases/current/doc/xproto/x11protocol.html#requests:CreateColormap
CreateColormap
1 78 opcode
1 alloc
0 None
1 All
2 4 request length
4 COLORMAP mid
4 WINDOW window
4 VISUALID visual
MadLittleMods
commented
Sep 15, 2023
| @@ -952,7 +954,7 @@ pub const window = struct { | |||
| save_under: bool = false, | |||
| event_mask: u32 = 0, | |||
| dont_propagate: u32 = 0, | |||
| colormap: Colormap = .copy_from_parent, | |||
| colormap: NonExhaustive(Colormap) = .copy_from_parent, | |||
There was a problem hiding this comment.
We are making this non-exhaustive so we can specify a custom color map ID
MadLittleMods
commented
Sep 15, 2023
| writeIntNative(u16, buf + 2, len >> 2); | ||
| writeIntNative(u32, buf + 4, id); | ||
| } | ||
| }; |
There was a problem hiding this comment.
X11 protocol docs: https://www.x.org/releases/current/doc/xproto/x11protocol.html#requests:FreeColormap
FreeColormap
1 79 opcode
1 unused
2 2 request length
4 COLORMAP cmap
This was referenced Sep 15, 2023
|
Commands look reasonable. Would be nice to add some usage of the commands to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create and specify custom color maps
Part of the quest for transparent windows/colors. I was able to get transparency/alpha working with these changes on top of #8. See MadLittleMods/fps-aim-analyzer#2 as an example.