Fix Datagrid bulkActionButtons shows empty toolbar when user cannot access the delete action #10347
+33
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ccess the delete action
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
djhi
reviewed
Nov 14, 2024
djhi
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Datagrid has built-in acess control. If the user cannot access the current resource with the
deleteaction, theBulkDeleteButtondoesn't appear.But the bulk action toolbar is still displayed in that case... empty.
Solution
Check the delete rights before setting the default
bulkActionToolbarvalue to hide the checkboxes when the user hasn't defined custom bulk actions and they don't have the delete rights.