Fix incorrect documentation of EditInDialogButton #10943
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Madeorsk
changed the title
Madeorsk
force-pushed
the
fix-edit-in-dialog-docs
branch
from
b07941b to
e7a94b9
Compare
Madeorsk
force-pushed
the
fix-edit-in-dialog-docs
branch
from
e7a94b9 to
0a94c8d
Compare
fzaninotto
requested changes
Sep 17, 2025
| fullWidth | ||
| maxWidth="md" | ||
| record={{ employer_id: record?.id }} // pre-populates the employer_id to link the new customer to the current employer | ||
| record={record} |
There was a problem hiding this comment.
this won't work, record is the current Employer, not the Customer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
EditInDialogButtonexamples incorrectly specify a record in theSimpleForm.Solution
Remove the record prop in these examples as it is only intended in a
CreateInDialogButton.Additional Checks
masterfor a bugfix or a documentation fix, ornextfor a feature[ ] The PR includes unit tests (if not possible, describe why)[ ] The PR includes one or several stories (if not possible, describe why)