Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Our packages exports are wrong, making them unusable in Node contexts (for instance when using SSR or RSC frameworks)
Solution
.js
extensions to ourlodash
imports as it causes issues in ESM setupHow To Test
make build
npm pack
in each package you'll want to use in the tests explained below. You'll have to move/copy them in avendor
directory and provide their path in your test applicationpackage.json
.ra-core
,ra-data-fakerest
,ra-i18n-polyglot
,ra-language-english
anddata-generator-retail
ESM
shadcn-admin-kit
vendor
directory:/admin
route:CJS
node-test
directorydata-generator-retail
from thevendor
directory as explained beforeindex.cjs
file with the following content:node ./index.cjs
Additional Checks
master
for a bugfix or a documentation fix, ornext
for a feature