Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Releases 2.13] Add support for legacy OpenAI CLIP model #1107

Merged
merged 3 commits into from
Jan 31, 2025

Conversation

wanliAlex
Copy link
Collaborator

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Bug fix

  • What is the current behavior? (You can also link to an open issue here)
    In release 2.12, we introduced a regression that the old OpenAI CLIP model (e.g., ViT-B/32) can't be loaded properly. The tokenizer loading will error out.

  • What is the new behavior (if this is a feature change)?
    We fix this bug. The model can be loaded properly.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    no

  • Have unit tests been run against this PR? (Has there also been any additional testing?)
    yes

  • Related Python client changes (link commit/PR here)
    no

  • Related documentation changes (link commit/PR here)

  • Other information:

  • Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes / features)

@wanliAlex wanliAlex merged commit c05a794 into releases/2.13 Jan 31, 2025
8 of 9 checks passed
@wanliAlex wanliAlex deleted the li/fix-open-clip-load branch January 31, 2025 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants