Please review my PR and suggest the required changes #1
Conversation
README.md
Outdated
| A simulation of a basic drone model take-off up to a given altitude in a gazebo environment; with a PX4 autopilot supported by Mavros in Ubuntu. | ||
|
|
||
|  |
There was a problem hiding this comment.
images should be enclosed in <p></p> tags, so that they can be aligned in the center i.e align="center
README.md
Outdated
| <p align="justify">Finally, we needed a script for takeoff of our drone. A launch file was also needed. We create a python script in VS Code for this execution.</p> | ||
|
|
||
|  |
There was a problem hiding this comment.
instead of adding screenshots of code, you can use code-blocks
There was a problem hiding this comment.
By code-blocks I meant, adding a snippet of the code in the markdown/Readme file. for e.g.
def test():
return None
README.md
Outdated
|
|
||
| 1. [Nagesh Bansal](https://github.com/Nageshbansal) | ||
| 2. Harshini S. |
There was a problem hiding this comment.
add links to GitHub profiles for all of the mentors
| pass | ||
|
|
||
| def setTakeoff(self): | ||
| print('waiting for service') |
There was a problem hiding this comment.
add comments in code for each of the method/functions and classes
|
Sir I've made the changes, please review. |
README.md
Outdated
| A simulation of a basic drone model take-off up to a given altitude in a gazebo environment; with a PX4 autopilot supported by Mavros in Ubuntu. | ||
|
|
||
|  |
There was a problem hiding this comment.
images should be enclosed in the <p> tags, so that they can be aligned in the center
README.md
Outdated
| <p align="justify">Finally, we needed a script for takeoff of our drone. A launch file was also needed. We create a python script in VS Code for this execution. | ||
|
|
||
|  |
There was a problem hiding this comment.
instead of adding screenshots of the code, you can add snippets or just add the URL to the script.
|
Sir I have done all the changes recommended by you. |
There was a problem hiding this comment.
- remove the screenshots of the code from the
images and videosdirectory - add report in the
Poster and Reportdirectory - Instead of adding link to the script, you can add a snippet of the code in your markdown, you can follow this tutorial for your reference https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/creating-and-highlighting-code-blocks
|
Yes Sir, I've done all the changes. Please review. |
|
Sir I've converted the report in pdf form. |
|
Are you done with all of the mentioned changes? |
|
Yes Sir |
@Nageshbansal Follow this up and tag me once the repo is ready for merge. |
|
SIr, I've done the changes |
There was a problem hiding this comment.
LGTM, Good work.
@SanjeevKrishnan, I think we're done with changes, let me know if we can merge this PR.
No description provided.