PR -Smart door lock; plz review it #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 22773e8.
README.md
Outdated
| * PCB designing | ||
|
|
||
| <img width="674" alt="Final ckt" src="https://user-images.githubusercontent.com/109852675/180622980-73ec9dae-7ab8-48cd-b12d-f95311ac56dc.png"> |
There was a problem hiding this comment.
tags should be in
<p></p>, so that image can align in center.
|
|
||
|
|
||
| ## Cost Structure |
There was a problem hiding this comment.
cost of components should be in a table.
----------------------------
components | Price |
----------------------------
README.md
Outdated
| ## Team Members | ||
|
|
||
| 1. Manmanth Ashtikar (https://github.com/ashtikarmanmath) |
There was a problem hiding this comment.
you can use hyperlinks. [name](url)
| #include <ArduinoIoTCloud.h> | ||
| #include <Arduino_ConnectionHandler.h> | ||
|
|
||
| const char DEVICE_LOGIN_NAME[] = "bd95aeec-8969-4784-8675-a7cdd2077f8d"; |
Nageshbansal
reviewed
Aug 7, 2022
|
And resolve the previous conservation ASAP |
|
Do not create multiple PRs. Close the unnecessary PRs. Finish your documentation ASAP. |
Nageshbansal
requested changes
Aug 25, 2022
There was a problem hiding this comment.
@ashtikarmanmath Thanks for the PR, there are some changes you need to do:
- Report in the
.pdfformat - Code should be in the respective file format .i.e Arduino code in the
.inofile not in the.txtfile - File names should be according to the given guidelines
- Justify the text in README.md
- Links to Mentor's GitHub profile
And Let me know when you're done with the changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.