Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Nodes and Redesign #80

Draft
wants to merge 47 commits into
base: main
Choose a base branch
from
Draft

ENH: Nodes and Redesign #80

wants to merge 47 commits into from

Conversation

marsipu
Copy link
Owner

@marsipu marsipu commented Apr 14, 2024 •
edited
Loading

This completely redesigns the frontend in favor of a node-centered approach. For the nodes modified code from NodeGraphQt is used.

Frontend

  • Implemented nodes with code from NodeGraphQt
  • Input nodes
  • Function nodes with parameters
  • AssignmentNode, GroupNode

Backend

  • Tests for new nodes
  • A new controller as session-object

Deprecated

  • Project-class: integrated into Controller as session-object
  • Parameter-View: now in Function-Nodes
  • Input-View: now in Input-Nodes
  • Custom function/parameters stored in .csv: Now in .json with higher inference directly from code and less attributes needed to assign

@marsipu marsipu added the enhancement New feature or request label Apr 14, 2024
@marsipu marsipu self-assigned this Apr 14, 2024
marsipu and others added 21 commits December 15, 2024 12:06
@marsipu
Merge branch 'main' into nodes
f610800
@marsipu
fix connected nodes
8fb7047
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
b46840d 
for more information, see https://pre-commit.ci
@marsipu
fix QPen.setStyle deprecated in PyQt6
7dfe8a8
@marsipu
Merge branch 'main' into nodes
968cd95
@marsipu
realizing that having inputs/outputs methods does make sense, because…
5c6d748 
… a unified ports-container would make having same-named ports (as for assignment-nodes) difficult with names as keys
@marsipu
update pre-commit hook version tags
10ae568
@marsipu
change default of label_time_course extraction_mode
4621866
@marsipu
connection initializing missing
10c625b
@marsipu
add docformatter
9d0c093
@marsipu
remove unnecessary line (test docformatter)
f0b3278
@marsipu
test again
6554a0e
@marsipu
apply docformatter
bd5468f
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
64a0f6f 
for more information, see https://pre-commit.ci
@marsipu
begin transition to remove set_output/set_input
a32cf86
@marsipu
make main run again
0f12154
@marsipu
fix cluttered error messages in console
f35a316
@marsipu
fix bugs
5d28515
@marsipu
fix bugs
c48af51
@marsipu
Merge branch 'main' into nodes
91749ef
@marsipu
add some directions
fccf3ce
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@marsipu marsipu

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@marsipu