Skip to content

Commit

Permalink
minor accessibility improvements
Browse files Browse the repository at this point in the history
  • Loading branch information
marticliment committed Mar 16, 2024
1 parent 6c6d407 commit 850864c
Show file tree
Hide file tree
Showing 12 changed files with 65 additions and 77 deletions.
15 changes: 9 additions & 6 deletions src/wingetui/Interface/SoftwarePages/DiscoverPackages.xaml
Original file line number Diff line number Diff line change
Expand Up @@ -621,10 +621,10 @@
<ColumnDefinition Width="Auto"/>
</Grid.ColumnDefinitions>
<TextBox Grid.Column="0" x:Name="QueryBlock" Height="30" CornerRadius="4,0,0,4" Padding="7,5,5,5"
VerticalContentAlignment="Center"
VerticalContentAlignment="Center"
/>
<Button Grid.Column="1" x:Name="FindButton" CornerRadius="0,4,4,0"
Height="32" Width="30" Padding="4">
Height="32" Width="30" Padding="4" AutomationProperties.HelpText="Search">
<AnimatedIcon>
<AnimatedIcon.Source>
<animatedvisuals:AnimatedFindVisualSource/>
Expand All @@ -635,7 +635,7 @@
</AnimatedIcon>
</Button>
<Button Grid.Column="2" x:Name="ReloadButton" CornerRadius="4"
Margin="6,0,4,0" Padding="0"
Margin="6,0,4,0" Padding="0" AutomationProperties.HelpText="Reload packages"
Height="32" Width="32">
<FontIcon Glyph="&#xE72C;" FontSize="16"/>
</Button>
Expand Down Expand Up @@ -672,7 +672,8 @@
<!-- Sources Expander -->
<Expander Grid.Row="0" Grid.Column="0" HorizontalAlignment="Stretch" CornerRadius="8"
IsExpanded="True" Background="{ThemeResource SystemFillColorNeutralBackgroundBrush}"
Padding="4,4,4,8" HorizontalContentAlignment="Stretch">
Padding="4,4,4,8" HorizontalContentAlignment="Stretch"
AutomationProperties.Name="Filter by source">
<Expander.Header>
<StackPanel Orientation="Horizontal" Spacing="8">
<FontIcon Glyph="&#xE74C;" FontSize="20"/>
Expand Down Expand Up @@ -709,7 +710,8 @@
<!-- Filter Options Expander -->
<Expander Grid.Row="1" Grid.Column="0" HorizontalAlignment="Stretch" CornerRadius="8"
IsExpanded="True" Background="{ThemeResource SystemFillColorNeutralBackgroundBrush}"
Padding="16,8,16,8" HorizontalContentAlignment="Stretch">
Padding="16,8,16,8" HorizontalContentAlignment="Stretch"
AutomationProperties.Name="Filter options">
<Expander.Header>
<StackPanel Orientation="Horizontal" Spacing="8">
<FontIcon Glyph="&#xE71C;" FontSize="20"/>
Expand Down Expand Up @@ -739,7 +741,8 @@
<!-- Search Mode Expander -->
<Expander Grid.Row="2" Grid.Column="0" HorizontalAlignment="Stretch" CornerRadius="8"
IsExpanded="True" Background="{ThemeResource SystemFillColorNeutralBackgroundBrush}"
Padding="16,8,16,8" HorizontalContentAlignment="Stretch">
Padding="16,8,16,8" HorizontalContentAlignment="Stretch"
AutomationProperties.Name="Search mode">
<Expander.Header>
<StackPanel Orientation="Horizontal" Spacing="8">
<FontIcon Glyph="&#xE773;" FontSize="20"/>
Expand Down
2 changes: 2 additions & 0 deletions src/wingetui/Interface/SoftwarePages/DiscoverPackages.xaml.cs
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,8 @@ public DiscoverPackagesPage()
LoadInterface();
_ = __load_packages();

QueryBlock.PlaceholderText = Tools.Translate("Search for packages");

}

protected async Task __load_packages()
Expand Down
13 changes: 8 additions & 5 deletions src/wingetui/Interface/SoftwarePages/InstalledPackages.xaml
Original file line number Diff line number Diff line change
Expand Up @@ -624,7 +624,7 @@
VerticalContentAlignment="Center"
/>
<Button Grid.Column="1" x:Name="FindButton" CornerRadius="0,4,4,0"
Height="32" Width="30" Padding="4">
Height="32" Width="30" Padding="4" AutomationProperties.HelpText="Search">
<AnimatedIcon>
<AnimatedIcon.Source>
<animatedvisuals:AnimatedFindVisualSource/>
Expand All @@ -635,7 +635,7 @@
</AnimatedIcon>
</Button>
<Button Grid.Column="2" x:Name="ReloadButton" CornerRadius="4"
Margin="6,0,4,0" Padding="0"
Margin="6,0,4,0" Padding="0" AutomationProperties.HelpText="Reload packages"
Height="32" Width="32">
<FontIcon Glyph="&#xE72C;" FontSize="16"/>
</Button>
Expand Down Expand Up @@ -672,7 +672,8 @@
<!-- Sources Expander -->
<Expander Grid.Row="0" Grid.Column="0" HorizontalAlignment="Stretch" CornerRadius="8"
IsExpanded="True" Background="{ThemeResource SystemFillColorNeutralBackgroundBrush}"
Padding="4,4,4,8" HorizontalContentAlignment="Stretch">
Padding="4,4,4,8" HorizontalContentAlignment="Stretch"
AutomationProperties.Name="Filter by source">
<Expander.Header>
<StackPanel Orientation="Horizontal" Spacing="8">
<FontIcon Glyph="&#xE74C;" FontSize="20"/>
Expand Down Expand Up @@ -709,7 +710,8 @@
<!-- Filter Options Expander -->
<Expander Grid.Row="1" Grid.Column="0" HorizontalAlignment="Stretch" CornerRadius="8"
IsExpanded="False" Background="{ThemeResource SystemFillColorNeutralBackgroundBrush}"
Padding="16,8,16,8" HorizontalContentAlignment="Stretch">
Padding="16,8,16,8" HorizontalContentAlignment="Stretch"
AutomationProperties.Name="Filter options">
<Expander.Header>
<StackPanel Orientation="Horizontal" Spacing="8">
<FontIcon Glyph="&#xE71C;" FontSize="20"/>
Expand Down Expand Up @@ -739,7 +741,8 @@
<!-- Search mode Expander -->
<Expander Grid.Row="2" Grid.Column="0" HorizontalAlignment="Stretch" CornerRadius="8"
IsExpanded="False" Background="{ThemeResource SystemFillColorNeutralBackgroundBrush}"
Padding="16,8,16,8" HorizontalContentAlignment="Stretch">
Padding="16,8,16,8" HorizontalContentAlignment="Stretch"
AutomationProperties.Name="Search mode">
<Expander.Header>
<StackPanel Orientation="Horizontal" Spacing="8">
<FontIcon Glyph="&#xE773;" FontSize="20"/>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,8 @@ public InstalledPackagesPage()
GenerateToolBar();
LoadInterface();
_ = LoadPackages();

QueryBlock.PlaceholderText = Tools.Translate("Search for packages");
}

public void ReloadPackages()
Expand Down
11 changes: 7 additions & 4 deletions src/wingetui/Interface/SoftwarePages/PackageBundle.xaml
Original file line number Diff line number Diff line change
Expand Up @@ -625,7 +625,7 @@
VerticalContentAlignment="Center"
/>
<Button Grid.Column="1" x:Name="FindButton" CornerRadius="0,4,4,0"
Height="32" Width="30" Padding="4">
Height="32" Width="30" Padding="4" AutomationProperties.HelpText="Search">
<AnimatedIcon>
<AnimatedIcon.Source>
<animatedvisuals:AnimatedFindVisualSource/>
Expand Down Expand Up @@ -673,7 +673,8 @@
<!-- Sources Expander -->
<Expander Grid.Row="0" Grid.Column="0" HorizontalAlignment="Stretch" CornerRadius="8"
IsExpanded="True" Background="{ThemeResource SystemFillColorNeutralBackgroundBrush}"
Padding="4,4,4,8" HorizontalContentAlignment="Stretch">
Padding="4,4,4,8" HorizontalContentAlignment="Stretch"
AutomationProperties.Name="Filter by source">
<Expander.Header>
<StackPanel Orientation="Horizontal" Spacing="8">
<FontIcon Glyph="&#xE74C;" FontSize="20"/>
Expand Down Expand Up @@ -710,7 +711,8 @@
<!-- Filter Options Expander -->
<Expander Grid.Row="1" Grid.Column="0" HorizontalAlignment="Stretch" CornerRadius="8"
IsExpanded="False" Background="{ThemeResource SystemFillColorNeutralBackgroundBrush}"
Padding="16,8,16,8" HorizontalContentAlignment="Stretch">
Padding="16,8,16,8" HorizontalContentAlignment="Stretch"
AutomationProperties.Name="Filter options">
<Expander.Header>
<StackPanel Orientation="Horizontal" Spacing="8">
<FontIcon Glyph="&#xE71C;" FontSize="20"/>
Expand Down Expand Up @@ -740,7 +742,8 @@
<!-- Search Mode Expander -->
<Expander Grid.Row="2" Grid.Column="0" HorizontalAlignment="Stretch" CornerRadius="8"
IsExpanded="False" Background="{ThemeResource SystemFillColorNeutralBackgroundBrush}"
Padding="16,8,16,8" HorizontalContentAlignment="Stretch">
Padding="16,8,16,8" HorizontalContentAlignment="Stretch"
AutomationProperties.Name="Search mode">
<Expander.Header>
<StackPanel Orientation="Horizontal" Spacing="8">
<FontIcon Glyph="&#xE773;" FontSize="20"/>
Expand Down
1 change: 1 addition & 0 deletions src/wingetui/Interface/SoftwarePages/PackageBundle.xaml.cs
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,7 @@ public PackageBundlePage()

GenerateToolBar();
LoadInterface();
QueryBlock.PlaceholderText = Tools.Translate("Search for packages");
}


Expand Down
13 changes: 8 additions & 5 deletions src/wingetui/Interface/SoftwarePages/SoftwareUpdates.xaml
Original file line number Diff line number Diff line change
Expand Up @@ -639,7 +639,7 @@
VerticalContentAlignment="Center"
/>
<Button Grid.Column="1" x:Name="FindButton" CornerRadius="0,4,4,0"
Height="32" Width="30" Padding="4">
Height="32" Width="30" Padding="4" AutomationProperties.HelpText="Search">
<AnimatedIcon>
<AnimatedIcon.Source>
<animatedvisuals:AnimatedFindVisualSource/>
Expand All @@ -650,7 +650,7 @@
</AnimatedIcon>
</Button>
<Button Grid.Column="2" x:Name="ReloadButton" CornerRadius="4"
Margin="6,0,4,0" Padding="0"
Margin="6,0,4,0" Padding="0" AutomationProperties.HelpText="Reload packages"
Height="32" Width="32">
<FontIcon Glyph="&#xE72C;" FontSize="16"/>
</Button>
Expand Down Expand Up @@ -687,7 +687,8 @@
<!-- Sources Expander -->
<Expander Grid.Row="0" Grid.Column="0" HorizontalAlignment="Stretch" CornerRadius="8"
IsExpanded="True" Background="{ThemeResource SystemFillColorNeutralBackgroundBrush}"
Padding="4,4,4,8" HorizontalContentAlignment="Stretch">
Padding="4,4,4,8" HorizontalContentAlignment="Stretch"
AutomationProperties.Name="Filter by sources">
<Expander.Header>
<StackPanel Orientation="Horizontal" Spacing="8">
<FontIcon Glyph="&#xE74C;" FontSize="20"/>
Expand Down Expand Up @@ -725,7 +726,8 @@
<!-- Filter Options Expander -->
<Expander Grid.Row="1" Grid.Column="0" HorizontalAlignment="Stretch" CornerRadius="8"
IsExpanded="False" Background="{ThemeResource SystemFillColorNeutralBackgroundBrush}"
Padding="16,8,16,8" HorizontalContentAlignment="Stretch">
Padding="16,8,16,8" HorizontalContentAlignment="Stretch"
AutomationProperties.Name="Filter options">
<Expander.Header>
<StackPanel Orientation="Horizontal" Spacing="8">
<FontIcon Glyph="&#xE71C;" FontSize="20"/>
Expand Down Expand Up @@ -755,7 +757,8 @@
<!-- Search mode expander -->
<Expander Grid.Row="2" Grid.Column="0" HorizontalAlignment="Stretch" CornerRadius="8"
IsExpanded="False" Background="{ThemeResource SystemFillColorNeutralBackgroundBrush}"
Padding="16,8,16,8" HorizontalContentAlignment="Stretch">
Padding="16,8,16,8" HorizontalContentAlignment="Stretch"
AutomationProperties.Name="Search mode">
<Expander.Header>
<StackPanel Orientation="Horizontal" Spacing="8">
<FontIcon Glyph="&#xE773;" FontSize="20"/>
Expand Down
2 changes: 2 additions & 0 deletions src/wingetui/Interface/SoftwarePages/SoftwareUpdates.xaml.cs
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,8 @@ public SoftwareUpdatesPage()
GenerateToolBar();
LoadInterface();
_ = LoadPackages(ManualCheck: false);

QueryBlock.PlaceholderText = Tools.Translate("Search for packages");
}

protected void AddPackageToSourcesList(UpgradablePackage package)
Expand Down
2 changes: 1 addition & 1 deletion src/wingetui/Interface/Widgets/Announcer.xaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
mc:Ignorable="d">

<Grid>
<Grid TabIndex="99">
<Grid x:Name="g">
<Grid.RowDefinitions>
<RowDefinition Height="80"/>
Expand Down
3 changes: 2 additions & 1 deletion src/wingetui/Interface/Widgets/Announcer.xaml.cs
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,8 @@ public Announcer()
DefaultStyleKey = typeof(Announcer);
BringIntoViewRequested += (s, e) => { LoadAnnouncements(); };

PointerPressed += (s, e) => { LoadAnnouncements(); };
int i = 0;
PointerPressed += (s, e) => { if(i++ %3 != 0) LoadAnnouncements(); };

SetText(binder.Translate("Fetching latest announcements, please wait..."));
_textblock.TextWrapping = TextWrapping.Wrap;
Expand Down
Loading

0 comments on commit 850864c

Please sign in to comment.