Scoop: don't show success when internet drop and pwsh script crashes (f…

…ix #3186)
marticliment · Jan 17, 2025 · a3c0f0b · a3c0f0b
1 parent 2ea0871
commit a3c0f0b
Showing 1 changed file with 4 additions and 6 deletions.
diff --git a/src/UniGetUI.PackageEngine.Managers.Scoop/Helpers/ScoopPkgOperationHelper.cs b/src/UniGetUI.PackageEngine.Managers.Scoop/Helpers/ScoopPkgOperationHelper.cs
@@ -85,12 +85,10 @@ protected override OperationVeredict _getOperationResult(
 
             return OperationVeredict.Failure;
         }
-        else
-        {
-            if (output_string.Contains("ERROR"))
-                return OperationVeredict.Failure;
 
-            return OperationVeredict.Success;
-        }
+        if (output_string.Contains("ERROR"))
+            return OperationVeredict.Failure;
+
+        return returnCode == 0? OperationVeredict.Success: OperationVeredict.Failure;
     }
 }