Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempted fix for #2879 #2880

Merged
merged 3 commits into from
Oct 23, 2024
Merged

Attempted fix for #2879 #2880

merged 3 commits into from
Oct 23, 2024

Conversation

Mertsch
Copy link
Contributor

@Mertsch Mertsch commented Oct 23, 2024

  • I have read the contributing guidelines, and I agree with the Code of Conduct.
  • Have you checked that there aren't other open pull requests for the same changes?
  • Have you tested that the committed code can be executed without errors?
  • This PR is not composed of garbage changes used to farm GitHub activity to enter potential Crypto AirDrops.
    Any user suspected of farming GitHub activity with crypto purposes will get banned. Submitting broken code wastes the contributors' time, who have to spend their free time reviewing, fixing, and testing code that does not even compile breaks other features, or does not introduce any useful changes. I appreciate your understanding.

Relates to #2879

@Mertsch Mertsch changed the title Patch 1 Attempted fix for #2879 Oct 23, 2024
@marticliment marticliment merged commit 48c96b0 into marticliment:main Oct 23, 2024
2 checks passed
@Mertsch Mertsch deleted the patch-1 branch October 23, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marticliment marticliment marticliment approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mertsch @marticliment