Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Operations redesign #3070

Merged
merged 46 commits into from
Dec 31, 2024
Merged

Operations redesign #3070

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
46 commits
Select commit Hold shift + click to select a range
09ac2a6
Update NuGet packages
marticliment Dec 13, 2024
1308be7
fix some warnings
marticliment Dec 13, 2024
444678d
Make the OperationsList resizable
marticliment Dec 13, 2024
982126a
Add collapse/expand all button, add menu to cancell all and to put al…
marticliment Dec 14, 2024
3b6f999
Implement cancel all, add more options to menu
marticliment Dec 15, 2024
5ad80b3
Add new AbstractOperation and AbstractProcessOperation classes
marticliment Dec 23, 2024
a5f6c82
Move AbstractOperation to using events
marticliment Dec 24, 2024
389334c
Finish porting package and source operations to new AbstractOperation
marticliment Dec 24, 2024
6278fb9
[nonworking] add final architecture of new operations
marticliment Dec 24, 2024
18b3fa8
now it builds
marticliment Dec 24, 2024
ebf651c
Merge branch 'main' into operations-redesign
marticliment Dec 24, 2024
3bc0a22
Change framework monikers so HotReload works on JetBrainsRider
marticliment Dec 24, 2024
b94a25c
Update ExternalLibraries.WindowsPackageManager.Interop.csproj
marticliment Dec 24, 2024
a1fa067
Make a Operations capsule on MainApp
marticliment Dec 24, 2024
234773e
Operations now run, although without output (currently)
marticliment Dec 24, 2024
8df8a1c
Add AbstractOperation.Metadata to centralize operation information (t…
marticliment Dec 25, 2024
7445bff
Migrate SourceOperations notifications to Metadata.*
marticliment Dec 25, 2024
110c760
Migrate operation information line to AbstractOperation.Metadata
marticliment Dec 25, 2024
48c5b59
Move notification handling to OperationControl
marticliment Dec 25, 2024
f330b48
Move PackageOperations and SourceOperations out from the UI
marticliment Dec 25, 2024
0bd142f
Remove code
marticliment Dec 25, 2024
3398076
Add Live Log window
marticliment Dec 25, 2024
fb373a9
Remove commented code
marticliment Dec 26, 2024
6cbad27
Update AbstractOperation.cs
marticliment Dec 26, 2024
70289bb
Minor tooltip improvements, migrate part of the missing functionality…
marticliment Dec 26, 2024
f7fa0a6
Implement Restart method, improve cancel detection on ProcessOperations
marticliment Dec 26, 2024
fa71a8a
Automatically scroll operation list to the ongoing operation
marticliment Dec 26, 2024
839e7b6
Improve cancel operation experience
marticliment Dec 26, 2024
d2e222e
Retry operaitons with different methods via the OperationFailed dialog
marticliment Dec 28, 2024
fa8fa5d
Fix a situation where an operation would crash and other pending oper…
marticliment Dec 28, 2024
6e26d61
Handle an edge case where WinGet COM would crash
marticliment Dec 28, 2024
7012adf
Merge branch 'main' into operations-redesign
marticliment Dec 28, 2024
68bbf14
Add a context menu to operations
marticliment Dec 29, 2024
4c84c4a
OperationControl Layout improvements
marticliment Dec 29, 2024
2febeff
Merge branch 'main' into operations-redesign
marticliment Dec 29, 2024
50710f6
Add queue control options on the menu
marticliment Dec 29, 2024
76a2073
Merge branch 'operations-redesign' of https://github.com/marticliment…
marticliment Dec 29, 2024
b5b46d9
Add base working for operation badges
marticliment Dec 30, 2024
77459ec
Make operation badges appear when required
marticliment Dec 31, 2024
0a7190e
Improvements to the More button on OperationControls
marticliment Dec 31, 2024
ac8b768
Scope badges seem to be confusing
marticliment Dec 31, 2024
9d7cc1a
Add the ability to control how many operations are performed in parallel
marticliment Dec 31, 2024
36397fe
Handle an edge case where UniGetUI wouldn't recognize the end of an o…
marticliment Dec 31, 2024
d7bdd0e
Merge branch 'main' into operations-redesign
marticliment Dec 31, 2024
d3b50f0
Finish the menu on the operation list resizable bar
marticliment Dec 31, 2024
daa6028
Merge branch 'operations-redesign' of https://github.com/marticliment…
marticliment Dec 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/UniGetUI.Core.Classes.Tests/UniGetUI.Core.Classes.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net8.0-windows10.0.22621.0</TargetFramework>
<TargetFramework>net8.0-windows10.0.26100.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<RuntimeIdentifiers>win-x64;win-arm64</RuntimeIdentifiers>
<RuntimeIdentifier>win-$(Platform)</RuntimeIdentifier>
Expand Down
2 changes: 1 addition & 1 deletion src/UniGetUI.Core.Classes/UniGetUI.Core.Classes.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net8.0-windows10.0.22621.0</TargetFramework>
<TargetFramework>net8.0-windows10.0.26100.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<RuntimeIdentifiers>win-x64;win-arm64</RuntimeIdentifiers>
<RuntimeIdentifier>win-$(Platform)</RuntimeIdentifier>
Expand Down
2 changes: 1 addition & 1 deletion src/UniGetUI.Core.Data.Tests/UniGetUI.Core.Data.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net8.0-windows10.0.22621.0</TargetFramework>
<TargetFramework>net8.0-windows10.0.26100.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<RuntimeIdentifiers>win-x64;win-arm64</RuntimeIdentifiers>
<RuntimeIdentifier>win-$(Platform)</RuntimeIdentifier>
Expand Down
2 changes: 1 addition & 1 deletion src/UniGetUI.Core.Data/UniGetUI.Core.Data.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net8.0-windows10.0.22621.0</TargetFramework>
<TargetFramework>net8.0-windows10.0.26100.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<RuntimeIdentifiers>win-x64;win-arm64</RuntimeIdentifiers>
<RuntimeIdentifier>win-$(Platform)</RuntimeIdentifier>
Expand Down
3 changes: 2 additions & 1 deletion src/UniGetUI.Core.IconEngine.Tests/UniGetUI.Core.IconEngine.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net8.0-windows10.0.22621.0</TargetFramework>
<TargetFramework>net8.0-windows10.0.26100.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<RuntimeIdentifiers>win-x64;win-arm64</RuntimeIdentifiers>
<RuntimeIdentifier>win-$(Platform)</RuntimeIdentifier>
Expand Down Expand Up @@ -29,6 +29,7 @@
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.12.0" />
<PackageReference Include="PhotoSauce.MagicScaler" Version="0.15.0" />
<PackageReference Include="xunit" Version="2.9.2" />
<PackageReference Include="xunit.analyzers" Version="1.17.0">
<PrivateAssets>all</PrivateAssets>
Expand Down
4 changes: 2 additions & 2 deletions src/UniGetUI.Core.IconStore/UniGetUI.Core.IconEngine.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net8.0-windows10.0.22621.0</TargetFramework>
<TargetFramework>net8.0-windows10.0.26100.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<RuntimeIdentifiers>win-x64;win-arm64</RuntimeIdentifiers>
<RuntimeIdentifier>win-$(Platform)</RuntimeIdentifier>
Expand Down Expand Up @@ -30,7 +30,7 @@
</ItemGroup>

<ItemGroup>
<PackageReference Include="PhotoSauce.MagicScaler" Version="0.14.2" />
<PackageReference Include="PhotoSauce.MagicScaler" Version="0.15.0" />
<PackageReference Include="System.Drawing.Common" Version="9.0.0" />
</ItemGroup>
</Project>
2 changes: 1 addition & 1 deletion src/UniGetUI.Core.Language.Tests/UniGetUI.Core.LanguageEngine.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net8.0-windows10.0.22621.0</TargetFramework>
<TargetFramework>net8.0-windows10.0.26100.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<RuntimeIdentifiers>win-x64;win-arm64</RuntimeIdentifiers>
<RuntimeIdentifier>win-$(Platform)</RuntimeIdentifier>
Expand Down
1 change: 0 additions & 1 deletion src/UniGetUI.Core.LanguageEngine/LanguageData.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,6 @@ private static Person[] LoadLanguageTranslatorList()
result.Add(person);
}
}

return result.ToArray();
}
}
Expand Down
2 changes: 1 addition & 1 deletion src/UniGetUI.Core.LanguageEngine/UniGetUI.Core.LanguageEngine.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net8.0-windows10.0.22621.0</TargetFramework>
<TargetFramework>net8.0-windows10.0.26100.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<RuntimeIdentifiers>win-x64;win-arm64</RuntimeIdentifiers>
<RuntimeIdentifier>win-$(Platform)</RuntimeIdentifier>
Expand Down
2 changes: 1 addition & 1 deletion src/UniGetUI.Core.Logger/UniGetUI.Core.Logging.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net8.0-windows10.0.22621.0</TargetFramework>
<TargetFramework>net8.0-windows10.0.26100.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<RuntimeIdentifiers>win-x64;win-arm64</RuntimeIdentifiers>
<RuntimeIdentifier>win-$(Platform)</RuntimeIdentifier>
Expand Down
2 changes: 1 addition & 1 deletion src/UniGetUI.Core.Logging.Tests/UniGetUI.Core.Logging.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net8.0-windows10.0.22621.0</TargetFramework>
<TargetFramework>net8.0-windows10.0.26100.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<RuntimeIdentifiers>win-x64;win-arm64</RuntimeIdentifiers>
<RuntimeIdentifier>win-$(Platform)</RuntimeIdentifier>
Expand Down
2 changes: 1 addition & 1 deletion src/UniGetUI.Core.Settings.Tests/UniGetUI.Core.Settings.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net8.0-windows10.0.22621.0</TargetFramework>
<TargetFramework>net8.0-windows10.0.26100.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<RuntimeIdentifiers>win-x64;win-arm64</RuntimeIdentifiers>
<RuntimeIdentifier>win-$(Platform)</RuntimeIdentifier>
Expand Down
2 changes: 1 addition & 1 deletion src/UniGetUI.Core.Settings/UniGetUI.Core.Settings.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net8.0-windows10.0.22621.0</TargetFramework>
<TargetFramework>net8.0-windows10.0.26100.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<RuntimeIdentifiers>win-x64;win-arm64</RuntimeIdentifiers>
<RuntimeIdentifier>win-$(Platform)</RuntimeIdentifier>
Expand Down
2 changes: 1 addition & 1 deletion src/UniGetUI.Core.Tools.Tests/UniGetUI.Core.Tools.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net8.0-windows10.0.22621.0</TargetFramework>
<TargetFramework>net8.0-windows10.0.26100.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<RuntimeIdentifiers>win-x64;win-arm64</RuntimeIdentifiers>
<RuntimeIdentifier>win-$(Platform)</RuntimeIdentifier>
Expand Down
2 changes: 1 addition & 1 deletion src/UniGetUI.Core.Tools/UniGetUI.Core.Tools.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net8.0-windows10.0.22621.0</TargetFramework>
<TargetFramework>net8.0-windows10.0.26100.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<RuntimeIdentifiers>win-x64;win-arm64</RuntimeIdentifiers>
<RuntimeIdentifier>win-$(Platform)</RuntimeIdentifier>
Expand Down
7 changes: 6 additions & 1 deletion src/UniGetUI.Interface.BackgroundApi/UniGetUI.Interface.BackgroundApi.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net8.0-windows10.0.22621.0</TargetFramework>
<TargetFramework>net8.0-windows10.0.26100.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<RuntimeIdentifiers>win-x64;win-arm64</RuntimeIdentifiers>
<RuntimeIdentifier>win-$(Platform)</RuntimeIdentifier>
Expand All @@ -22,6 +22,11 @@
<PackageReference Include="Nancy.Hosting.Self" Version="2.0.0">
<NoWarn>NU1701</NoWarn>
</PackageReference>
<PackageReference Include="Newtonsoft.Json" Version="13.0.1" />
<PackageReference Include="PhotoSauce.MagicScaler" Version="0.15.0" />
<PackageReference Include="System.Net.Http" Version="4.3.4" />
<PackageReference Include="System.Private.Uri" Version="4.3.2" />
<PackageReference Include="System.Text.RegularExpressions" Version="4.3.1" />
</ItemGroup>

<ItemGroup>
Expand Down
6 changes: 5 additions & 1 deletion src/UniGetUI.PAckageEngine.Interfaces/UniGetUI.PackageEngine.Interfaces.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net8.0-windows10.0.22621.0</TargetFramework>
<TargetFramework>net8.0-windows10.0.26100.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<RuntimeIdentifiers>win-x64;win-arm64</RuntimeIdentifiers>
<RuntimeIdentifier>win-$(Platform)</RuntimeIdentifier>
Expand All @@ -22,6 +22,10 @@
<Configurations>Debug;Release</Configurations>
</PropertyGroup>

<ItemGroup>
<PackageReference Include="PhotoSauce.MagicScaler" Version="0.15.0" />
</ItemGroup>

<ItemGroup>
<ProjectReference Include="..\UniGetUI.Core.Classes\UniGetUI.Core.Classes.csproj" />
<ProjectReference Include="..\UniGetUI.Core.Data\UniGetUI.Core.Data.csproj" />
Expand Down
9 changes: 5 additions & 4 deletions src/UniGetUI.PackageEngine.Enums/Enums.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,15 +29,16 @@ public enum BundleFormatType

public enum OperationVeredict
{
Succeeded,
Failed,
Success,
Failure,
Canceled,
RestartRequired,
// RestartRequired,
AutoRetry,
}

public enum OperationStatus
{
Pending,
InQueue,
Running,
Succeeded,
Failed,
Expand Down
2 changes: 1 addition & 1 deletion src/UniGetUI.PackageEngine.Enums/UniGetUI.PackageEngine.Structs.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net8.0-windows10.0.22621.0</TargetFramework>
<TargetFramework>net8.0-windows10.0.26100.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<RuntimeIdentifiers>win-x64;win-arm64</RuntimeIdentifiers>
<RuntimeIdentifier>win-$(Platform)</RuntimeIdentifier>
Expand Down
6 changes: 3 additions & 3 deletions src/UniGetUI.PackageEngine.Managers.Cargo/Cargo.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,10 +146,10 @@ private IEnumerable<Package> GetPackages(LoggableTaskType taskType)
List<Package> Packages = [];
foreach(var match in TaskRecycler<List<Match>>.RunOrAttach(GetInstalledCommandOutput, 15))
{
var id = match.Groups[1].Value.Trim();
var id = match.Groups[1]?.Value?.Trim() ?? "";
var name = CoreTools.FormatAsName(id);
var oldVersion = match.Groups[2].Value;
var newVersion = match.Groups[3].Value;
var oldVersion = match.Groups[2]?.Value?.Trim() ?? "";
var newVersion = match.Groups[3]?.Value?.Trim() ?? "";
if(taskType is LoggableTaskType.ListUpdates && oldVersion != newVersion)
Packages.Add(new Package(name, id, oldVersion, newVersion, DefaultSource, this));
else if(taskType is LoggableTaskType.ListInstalledPackages)
Expand Down
2 changes: 1 addition & 1 deletion src/UniGetUI.PackageEngine.Managers.Cargo/Helpers/CargoPkgOperationHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,6 @@ protected override IEnumerable<string> _getOperationParameters(IPackage package,

protected override OperationVeredict _getOperationResult(IPackage package, OperationType operation, IEnumerable<string> processOutput, int returnCode)
{
return returnCode == 0 ? OperationVeredict.Succeeded : OperationVeredict.Failed;
return returnCode == 0 ? OperationVeredict.Success : OperationVeredict.Failure;
}
}
6 changes: 5 additions & 1 deletion src/UniGetUI.PackageEngine.Managers.Cargo/UniGetUI.PackageEngine.Managers.Cargo.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net8.0-windows10.0.22621.0</TargetFramework>
<TargetFramework>net8.0-windows10.0.26100.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<RuntimeIdentifiers>win-x64;win-arm64</RuntimeIdentifiers>
<RuntimeIdentifier>win-$(Platform)</RuntimeIdentifier>
Expand Down Expand Up @@ -35,4 +35,8 @@
<ItemGroup>
<Compile Include="..\SharedAssemblyInfo.cs" Link="SharedAssemblyInfo.cs" />
</ItemGroup>

<ItemGroup>
<PackageReference Include="PhotoSauce.MagicScaler" Version="0.15.0" />
</ItemGroup>
</Project>
7 changes: 4 additions & 3 deletions src/UniGetUI.PackageEngine.Managers.Chocolatey/Helpers/ChocolateyPkgOperationHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,12 +55,13 @@ protected override OperationVeredict _getOperationResult(
{
if(returnCode is 3010)
{
return OperationVeredict.RestartRequired;
return OperationVeredict.Success;
// return OperationVeredict.RestartRequired;
}

if (returnCode is 1641 or 1614 or 1605 or 0)
{
return OperationVeredict.Succeeded;
return OperationVeredict.Success;
}

string output_string = string.Join("\n", processOutput);
Expand All @@ -76,6 +77,6 @@ protected override OperationVeredict _getOperationResult(
return OperationVeredict.AutoRetry;
}

return OperationVeredict.Failed;
return OperationVeredict.Failure;
}
}
4 changes: 2 additions & 2 deletions src/UniGetUI.PackageEngine.Managers.Chocolatey/Helpers/ChocolateySourceHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,12 @@ public override string[] GetRemoveSourceParameters(IManagerSource source)

protected override OperationVeredict _getAddSourceOperationVeredict(IManagerSource source, int ReturnCode, string[] Output)
{
return ReturnCode == 0 ? OperationVeredict.Succeeded : OperationVeredict.Failed;
return ReturnCode == 0 ? OperationVeredict.Success : OperationVeredict.Failure;
}

protected override OperationVeredict _getRemoveSourceOperationVeredict(IManagerSource source, int ReturnCode, string[] Output)
{
return ReturnCode == 0 ? OperationVeredict.Succeeded : OperationVeredict.Failed;
return ReturnCode == 0 ? OperationVeredict.Success : OperationVeredict.Failure;
}

protected override IEnumerable<IManagerSource> GetSources_UnSafe()
Expand Down
6 changes: 5 additions & 1 deletion ...GetUI.PackageEngine.Managers.Chocolatey/UniGetUI.PackageEngine.Managers.Chocolatey.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net8.0-windows10.0.22621.0</TargetFramework>
<TargetFramework>net8.0-windows10.0.26100.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<RuntimeIdentifiers>win-x64;win-arm64</RuntimeIdentifiers>
<RuntimeIdentifier>win-$(Platform)</RuntimeIdentifier>
Expand Down Expand Up @@ -42,4 +42,8 @@
<ItemGroup>
<Compile Include="..\SharedAssemblyInfo.cs" Link="SharedAssemblyInfo.cs" />
</ItemGroup>

<ItemGroup>
<PackageReference Include="PhotoSauce.MagicScaler" Version="0.15.0" />
</ItemGroup>
</Project>
2 changes: 1 addition & 1 deletion src/UniGetUI.PackageEngine.Managers.Dotnet/Helpers/DotNetPkgOperationHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,6 @@ protected override OperationVeredict _getOperationResult(
IEnumerable<string> processOutput,
int returnCode)
{
return returnCode == 0 ? OperationVeredict.Succeeded : OperationVeredict.Failed;
return returnCode == 0 ? OperationVeredict.Success : OperationVeredict.Failure;
}
}
6 changes: 5 additions & 1 deletion src/UniGetUI.PackageEngine.Managers.Dotnet/UniGetUI.PackageEngine.Managers.Dotnet.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net8.0-windows10.0.22621.0</TargetFramework>
<TargetFramework>net8.0-windows10.0.26100.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<RuntimeIdentifiers>win-x64;win-arm64</RuntimeIdentifiers>
<RuntimeIdentifier>win-$(Platform)</RuntimeIdentifier>
Expand Down Expand Up @@ -36,4 +36,8 @@
<ItemGroup>
<Compile Include="..\SharedAssemblyInfo.cs" Link="SharedAssemblyInfo.cs" />
</ItemGroup>

<ItemGroup>
<PackageReference Include="PhotoSauce.MagicScaler" Version="0.15.0" />
</ItemGroup>
</Project>
6 changes: 5 additions & 1 deletion ...PackageEngine.Managers.Generic.NuGet/UniGetUI.PackageEngine.Managers.Generic.NuGet.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net8.0-windows10.0.22621.0</TargetFramework>
<TargetFramework>net8.0-windows10.0.26100.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<RuntimeIdentifiers>win-x64;win-arm64</RuntimeIdentifiers>
<RuntimeIdentifier>win-$(Platform)</RuntimeIdentifier>
Expand All @@ -26,4 +26,8 @@
<ItemGroup>
<Compile Include="..\SharedAssemblyInfo.cs" Link="SharedAssemblyInfo.cs" />
</ItemGroup>

<ItemGroup>
<PackageReference Include="PhotoSauce.MagicScaler" Version="0.15.0" />
</ItemGroup>
</Project>
2 changes: 1 addition & 1 deletion src/UniGetUI.PackageEngine.Managers.Npm/Helpers/NpmPkgOperationHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,6 @@ protected override OperationVeredict _getOperationResult(
IEnumerable<string> processOutput,
int returnCode)
{
return returnCode == 0 ? OperationVeredict.Succeeded : OperationVeredict.Failed;
return returnCode == 0 ? OperationVeredict.Success : OperationVeredict.Failure;
}
}
6 changes: 5 additions & 1 deletion src/UniGetUI.PackageEngine.Managers.Npm/UniGetUI.PackageEngine.Managers.Npm.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net8.0-windows10.0.22621.0</TargetFramework>
<TargetFramework>net8.0-windows10.0.26100.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<RuntimeIdentifiers>win-x64;win-arm64</RuntimeIdentifiers>
<RuntimeIdentifier>win-$(Platform)</RuntimeIdentifier>
Expand Down Expand Up @@ -35,4 +35,8 @@
<ItemGroup>
<Compile Include="..\SharedAssemblyInfo.cs" Link="SharedAssemblyInfo.cs" />
</ItemGroup>

<ItemGroup>
<PackageReference Include="PhotoSauce.MagicScaler" Version="0.15.0" />
</ItemGroup>
</Project>
Loading
Loading