Allow using HockeyAppSDK pod subspecs #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For my use case, I need to use both HockeyApp and AppCenter pods (AppCenter doesn't support feedback yet). Unfortunately, including both causes an error at compile time due to overlapping symbols. The solution was to use
pod 'HockeySDK', :subspecs => 'FeedbackOnlyLib'to only include the feedback pod spec. However, when doing thisRNHockeyApp.mhad multiple compilation errors due to referencing code that was not included via cocoapods.This PR adds the appropriate
#if HOCKEYSDK_FEATURE_...flags to allow compiling the react-native module with a subset of the HockeyAppSDK pod subspecs.