use ip --json route and filter with python #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 5760f3f.
This depends on the deprecated `virtinterfaced` which we are getting rid of. This code was both unnecessarily complicated, and also too arbitrary: It just took what interface appeared in `virsh iface-list` first. Change this to be more realistic: The test creates a new network which NATs to a host device, so in most practical cases that should be the one having the default route. Rename the function and add a comment to clarify this.
virtinterfaced is being deprecated [1], and at least some distros want to get rid of the dependency. Fixes cockpit-project#1777 [1] https://listman.redhat.com/archives/libvir-list/2020-December/msg00183.html
martinpitt
force-pushed
the
drop-virtinterfaced
branch
2 times, most recently
from
68ec0e9 to
b8b3be2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the test failures by using the fact all virtual bridges are
virbrN. Instead of gambling that the interfaces we want are first we filter out all the virtual interfaces. This leaves only the interfaces we want in the routes.