Switch to logger (#442)

* Switch to logger

Use logger rather than io:format when logging.  The ct tests have besn switched to log to file, testutil/init_per_suite/1 may offer useful guidance on configuring logger with leveled.

As all logs are produced by the leveled_log module, the MFA metadata is uninteresting for log outputs, but can be used for explicit filter controls for leveled logs.

* iolist_to_binary not unicode_binary()

logger filters will be error and be removed if the format line is a binary().  Must be either a charlist() or a unicode_binary() - so iolist_to_binary() can't be used

* Add metadata for filter

* Update test/end_to_end/tictac_SUITE.erl

Co-authored-by: Thomas Arts <[email protected]>

---------

Co-authored-by: Thomas Arts <[email protected]>

priv/leveled.schema

@@ -81,13 +81,18 @@
 ]}.
 
 %% @doc Log level
-%% Can be debug, info, warn, error or critical
+%% Can be debug, info, warning, error or critical
 %% Set the minimum log level to be used within leveled.  Leveled will log many
 %% lines to allow for stats to be etracted by those using log indexers such as
-%% Splunk
+%% Splunk.
+%% Logging will be via erlang logger, and so the destination will be defined
+%% by the configured log handlers of the erlang node which starts the bookie.
+%% All logs are from the leveled_log module, and so specific handling can be
+%% managed using filters on the first element of the MFS metadata, or setting
+%% the log level for that specific module.
 {mapping, "leveled.log_level", "leveled.log_level", [
   {default, info},
-  {datatype, atom}
+  {datatype, {enum, [debug, info, warning, error, critical]}}
 ]}.
 
 %% @doc The approximate size (in bytes) when a Journal file should be rolled.

src/leveled.app.src

@@ -4,10 +4,10 @@
   {vsn, git},
   {registered, []},
   {applications, [
-                  lz4,
-                  zstd,
                   kernel,
-                  stdlib
+                  stdlib,
+                  lz4,
+                  zstd
                  ]},
   {maintainers, ["Martin Sumner"]},
   {licenses, ["Apache"]},

src/leveled_bookie.erl

@@ -38,7 +38,7 @@
 
 -behaviour(gen_server).
 
--include("include/leveled.hrl").
+-include("leveled.hrl").
 
 -export([init/1,
         handle_call/3,

src/leveled_cdb.erl

@@ -42,13 +42,11 @@
 %% The first word is the corresponding hash value and the second word is a
 %% file pointer to the actual {key,value} tuple higher in the file.
 %%
-%%
-
 
 -module(leveled_cdb).
 
 -behaviour(gen_statem).
--include("include/leveled.hrl").
+-include("leveled.hrl").
 
 -export([init/1,
             callback_mode/0,

src/leveled_codec.erl

@@ -8,7 +8,7 @@
 
 -module(leveled_codec).
 
--include("include/leveled.hrl").
+-include("leveled.hrl").
 
 -export([
         inker_reload_strategy/1,

src/leveled_head.erl

@@ -16,7 +16,7 @@
 
 -module(leveled_head).
 
--include("include/leveled.hrl").
+-include("leveled.hrl").
 
 -export([key_to_canonicalbinary/1,
             build_head/2,

src/leveled_iclerk.erl

@@ -72,7 +72,7 @@
 
 -behaviour(gen_server).
 
--include("include/leveled.hrl").
+-include("leveled.hrl").
 
 -export([init/1,
         handle_call/3,

src/leveled_imanifest.erl

@@ -1,11 +1,8 @@
 %% -------- Inker Manifest ---------
 %% 
 
-
 -module(leveled_imanifest).
 
--include("include/leveled.hrl").
-
 -export([
         generate_entry/1,
         add_entry/3,

src/leveled_inker.erl

@@ -80,12 +80,11 @@
 %% TODO: how to instruct the files to close is tbd
 %%
 
-
 -module(leveled_inker).
 
 -behaviour(gen_server).
 
--include("include/leveled.hrl").
+-include("leveled.hrl").
 
 -export([init/1,
         handle_call/3,