cli: add test to ensure the default config has no symbol aliases #4437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yuja The "is this a symbol" check is a complete hack, but maybe that's OK. Let me know what you think. |
In #4432 I submitted a patch to ship a symbol alias in the default configuration. However, Yuya quickly pointed out that this isn't acceptable because symbols override all branch and tag names, meaning that the name `at` would have at best been taken away from users, and at worst been very confusing for them down the road had they ever tried to use it. I should have thought of this myself (I encountered it long ago when first using Jujutsu, actually) but didn't. Such is life. But this didn't cause any tests to fail, as it was not immediately clear this would impede anything or cause downstream behavioral changes; the problems it adds are actually latent and it's very possible someone will want to make the same mistake in the future. And Yuya might not be able to stop them (me) in time; requiring him to go out of his way and then handle the fallout. I'm not a fan of this. Instead, let's patch this latent hole for good, or until we decide otherwise, by applying the Beyonce Rule: "if you liked that behavior, then you shoulda put a test on it." Signed-off-by: Austin Seipp <[email protected]>
thoughtpolice
force-pushed
the
aseipp/push-qsmypxuqyqwv
branch
from
ef2c7f9
to
799511c
Compare
4 tasks
thoughtpolice
commented
Sep 11, 2024
| // and so testing for the presence of a closing parenthesis is | ||
| // sufficient to ensure we're not introducing a symbol. | ||
| if !alias.ends_with(")") { | ||
| anyhow::bail!( |
There was a problem hiding this comment.
Should just be return
That's good. We could also use That said, I think a comment like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #4432 I submitted a patch to ship a symbol alias in the default configuration. However, Yuya quickly pointed out that this isn't acceptable because symbols override all branch and tag names, meaning that the name
atwould have at best been taken away from users, and at worst been very confusing for them down the road had they ever tried to use it.I should have thought of this myself (I encountered it long ago when first using Jujutsu, actually) but didn't. Such is life.
But this didn't cause any tests to fail, as it was not immediately clear this would impede anything or cause downstream behavioral changes; the problems it adds are actually latent and it's very possible someone will want to make the same mistake in the future. And Yuya might not be able to stop them (me) in time; requiring him to go out of his way and then handle the fallout. I'm not a fan of this.
Instead, let's patch this latent hole for good, or until we decide otherwise, by applying the Beyonce Rule: "if you liked that behavior, then you shoulda put a test on it."
Checklist
If applicable:
CHANGELOG.md