Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add config for ignoring executable bit changes #4478

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add config for ignoring executable bit changes #4478

wants to merge 3 commits into from

Commits on Sep 24, 2024

  1. local_working_copy: Initial option for reporting exec bit changes on … 

    …Unix

This is just the initial support for the feature. Threading the value
into the working copy via user configuration is in the next commit.
    @wrzian
    wrzian committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    51d7d8e View commit details
    Browse the repository at this point in the history

  2. local_working_copy: Allow user to configure exec bit behavior on Unix

    @wrzian
    wrzian committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    660b01c View commit details
    Browse the repository at this point in the history

  3. diff_working_copies: Simplify tree checkout functions and update Diff… 

    …Side enum.

I got annoyed by the checkout function above in my previous commit and tried to
compress the code a bit, and I think the result is much nicer. I'm not certain
that a closure is the right solution here, but I think it becomes easier to
reason about the two temp filenames that get generated.

I initially changed Option<DiffSide> to a bool, but found an enum more meaningful
and more likely to be flexible in the future.

I also moved the instruction writing to its own function. This makes the main
`DiffEditWorkingCopies::check_out()` function is much nicer. 

J: This commit contains the following changes:
    @wrzian
    wrzian committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    3982b04 View commit details
    Browse the repository at this point in the history