[pull] develop from cpplint:develop #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
In the situation, where one git/svn/hg repository is located inside the directory tree of another, the search incorrectly selects the outer one instead of the inner one.
PiperOrigin-RevId: 480954960
There is no Common Lisp operator named PRINT-UNPRINTABLE-OBJECT. Given the context, it is certain that PRINT-UNREADABLE-OBJECT (www.lispworks.com/documentation/lw51/CLHS/Body/m_pr_unr.htm) was meant instead.
Fix PRINT-UNPRINTABLE-OBJECT
Update ts styleguide with latest google version
PiperOrigin-RevId: 489165518
Go Style Guide
PiperOrigin-RevId: 489255983
Go: Fix a logic error in an example.
s/Vimscript/Vim script/
PiperOrigin-RevId: 489430034
PiperOrigin-RevId: 489956630
Add link to the Go guide from README.md.
PiperOrigin-RevId: 493761232
PiperOrigin-RevId: 497970050
Internal Change.
pylint triggered: pylint: Command line or configuration file:1: UserWarning: Specifying exception names in the overgeneral-exceptions option without module name is deprecated and support for it will be removed in pylint 3.0. Use fully qualified name (maybe 'builtins.StandardError' ?) instead. pylint: Command line or configuration file:1: UserWarning: Specifying exception names in the overgeneral-exceptions option without module name is deprecated and support for it will be removed in pylint 3.0. Use fully qualified name (maybe 'builtins.Exception' ?) instead. pylint: Command line or configuration file:1: UserWarning: Specifying exception names in the overgeneral-exceptions option without module name is deprecated and support for it will be removed in pylint 3.0. Use fully qualified name (maybe 'builtins.BaseException' ?) instead. Suggestion works out.
"complex.h" was both a C99 System header and a old legacy C++ System header. These days, it can be expected that the C header is meant, so cpplint should treat it like that.
This code is not deleting the function (method) but is instead deleting the class! https://docs.astral.sh/ruff/rules/invalid-first-argument-name-for-method --------- Co-authored-by: Aaron Liu <[email protected]>
Remove my pathetic attempt at a debug print from unit tests Ignore reformatting commit from git blame gitignore pycharm and uv.lock evidently i was not feeling well --------- Co-authored-by: Christian Clauss <[email protected]>
% `ruff rule N802 ` # https://docs.astral.sh/ruff/rules/invalid-function-name --------- Co-authored-by: Aaron Liu <[email protected]>
Pytest functions are easier to read and maintain than classes. ``` ============================= 222 passed in 19.71s ============================= ```
Replace self.fail()s Fix edge case of verifying categories when running pytest on a specific function through module notation Fix indented parameter test Make _Seen_Error_Categories a set Make clitest setup and teardown conform to naming
".h" files don't, because many C++ headers also use this extension Closes #71 --------- Co-authored-by: Christian Clauss <[email protected]>
https://github.com/pre-commit/pre-commit-hooks https://github.com/MarcoGorelli/auto-walrus The three TODOs can be done in follow-on pull requests.
Implement PyPI’s [trusted publishing](https://docs.pypi.org/trusted-publishers/) and use the [sigstore/gh-action-sigstore-python GitHub Action](https://github.com/marketplace/actions/gh-action-sigstore-python) to sign the distribution packages. This script is from https://packaging.python.org/en/latest/guides/publishing-package-distribution-releases-using-github-actions-ci-cd-workflows An alternative would be to use https://docs.astral.sh/uv/guides/package running under https://github.com/astral-sh/setup-uv
Bump the date again before releasing 2.0.1, then squash and merge and release (remember to create a new tag and follow the testing process in CONTRIBUTING.rst). --------- Co-authored-by: Christian Clauss <[email protected]>
Pylint released their update on dedeprecating the getopt and optparse modules.Should merge this after we release 2.0.1. --------- Co-authored-by: Christian Clauss <[email protected]>
* increase default pytest timeout to 481s for debugging room * [remove duplicate boost sample for testing inspect headers](1e39bff) * [use pytest parametrized instead of parameterized & google todo credit](c0eb131) * add script to update CLI test definitions --------- Co-authored-by: Christian Clauss <[email protected]>
As a side note, we should probably consider not running filtered checks sometime in the future. Please squash on merge with GitHub's shiny button. --------- Co-authored-by: Christian Clauss <[email protected]>
<!--pre-commit.ci start--> updates: - [github.com/astral-sh/ruff-pre-commit: v0.11.2 → v0.11.4](astral-sh/ruff-pre-commit@v0.11.2...v0.11.4) <!--pre-commit.ci end--> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
https://pre-commit.ci is running on every pull request at https://results.pre-commit.ci/repo/github/47154941 so pre-commit does not also need to be run in GitHub Actions.
Fixes: #358 * #358 is too complex (which may lead to loopholes) and requires us to give special permissions to a GitHub Action that is not verified in the Marketplace. Given GitHub Actions software supply chain attacks in recent weeks, it is better to err on the side of precaution and run tests on all pull requests. --- <img width="1092" alt="Special permissions" src="https://github.com/user-attachments/assets/16471cee-7e30-4ecc-9c99-21fd6c07be56" />
Split out parentheses counting namespace consumption to have enough available conditional branches for next commit Add type hints # Conflicts: # cpplint.py
Fix whitespace/indentation_namespace false positive for member initializer lists (MemInitLists) Adds new _ConstructorInfo, _WrappedInfo, and _MemInitListInfo nesting stack element classes Remember last-popped nesting stack item Update descriptor.pb.cc to 2016-12-16 version (commit 183d31c)
Fixed blatantly incorrect date Including items that e.g. describe changes to the changelog just bloats the changelog. It's supposed to be the point of reference for consumer-facing changes IIRC. Before 2.0, no changelog talked about tooling that didn't affect the code or tests either.
No other open pull requests. @aaronliu0130 has landed some critical changes. * [x] Merge a new pull request that only updates the version number and updates CHANGELOG.rst. * [x] Go to https://github.com/cpplint/cpplint/releases/new * [x] Put in the NEW version number. * [x] Click the Generate release notes button * [x] Click the Save draft button and ask other maintainers to review. * [ ] Ship it and check https://pypi.org/project/cpplint after a few minutes. Draft release: https://github.com/cpplint/cpplint/releases/edit/untagged-bac3df867046406901f0 --------- Co-authored-by: Aaron Liu <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Per release policy
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )