Change logging to use WatchedFileHandler #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WatchedFileHandler checks if the file changed or is unavailable for writing before logging, and if so, reopens it. This is helpful when the log file gets closed due to intermittent problems with the file system.
luator
approved these changes
Apr 25, 2024
|
If you add the "closes #86" to the PR description, it should automatically close the issue upon merging. Seems in the title it doesn't work. |
mseitzer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WatchedFileHandler checks if the file changed or is unavailable for writing before logging, and if so, reopens it. This is helpful when the log file gets closed due to intermittent problems with the file system.
How I tested?
Running the local example, checking if logs are still written to the file.
Closes #86.