Add toml support #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mseitzer
reviewed
Oct 20, 2023
smart_settings/smart_settings.py
Outdated
| if filename.endswith(".json"): | ||
| with open(filename, "r") as f: | ||
| data = json.load(f, object_pairs_hook=NoDuplicateDict) | ||
| return data | ||
| elif filename.endswith(".yaml"): |
There was a problem hiding this comment.
This does not fit this PR, but as you are touching the file anyways: could you also make it select YAML if the file ends on .yml? This has been bugging me for some time.
|
Looks good, no objections! |
TOML files are read to dictionaries just like JSON or YAML, so to support them as well. TOML doesn't allow duplicate keys as per its standard, so no explicit check is needed for that. The `tomllib` package was added in Python 3.11. For older versions, the third-party package `tomli` can be used as replacement (`tomllib` is actually based on `tomli`, so they should be pretty compatible).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TOML files are read to dictionaries just like JSON or YAML, so to support them as well.
TOML doesn't allow duplicate keys as per its standard, so no explicit check is needed for that.
The
tomllibpackage was added in Python 3.11. For older versions, the third-party packagetomlican be used as replacement (tomllibis actually based ontomli, so they should be pretty compatible).Also fixes a bug:
load_raw_dict_from_file()now raises an error if an unsupported file type is passed.How I Tested
In combination with cluster_utils (converting an existing json config file to toml and running with that file).
Do not merge before