-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace DelegateProxy with concrete forward implementation #58
Open
toshi0383
wants to merge
4
commits into
marty-suzuki:master
Choose a base branch
from
toshi0383:ts-section
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,7 +13,13 @@ class ViewController: UIViewController { | |
|
||
@IBOutlet weak var tableView: UITableView! | ||
|
||
fileprivate var messages: [MessageModel] = [] | ||
private var sections: [[MessageModel]] = (1...10) | ||
.map { i -> [MessageModel] in | ||
(0..<i) | ||
.map { | ||
MessageModel(imageName: "marty1", message: "\($0) hello", time: "00:00") | ||
} | ||
} | ||
|
||
override func viewDidLoad() { | ||
super.viewDidLoad() | ||
|
@@ -39,28 +45,43 @@ class ViewController: UIViewController { | |
} | ||
|
||
@IBAction func addButtonTapped(_ sender: UIBarButtonItem) { | ||
let i = sections.count - 1 | ||
var messages = sections[i] | ||
messages.append(MessageModel()) | ||
sections[i] = messages | ||
tableView.beginUpdates() | ||
tableView.re.insertRows(at: [IndexPath(row: messages.count - 1, section: 0)], with: .automatic) | ||
tableView.re.insertRows(at: [IndexPath(row: messages.count - 1, section: i)], with: .automatic) | ||
tableView.endUpdates() | ||
} | ||
|
||
@IBAction func trashButtonTapped(_ sender: UIBarButtonItem) { | ||
messages.removeAll() | ||
sections.removeLast(max(0, sections.count - 1)) | ||
tableView.reloadData() | ||
} | ||
} | ||
|
||
extension ViewController: UITableViewDataSource { | ||
|
||
func numberOfSections(in tableView: UITableView) -> Int { | ||
sections.count | ||
} | ||
|
||
func tableView(_ tableView: UITableView, numberOfRowsInSection section: Int) -> Int { | ||
return messages.count | ||
sections[section].count | ||
} | ||
|
||
func tableView(_ tableView: UITableView, cellForRowAt indexPath: IndexPath) -> UITableViewCell { | ||
let cell = tableView.dequeueReusableCell(withIdentifier: "Cell", for: indexPath) | ||
let messages = sections[indexPath.section] | ||
(cell as? TableViewCell)?.configure(with: messages[indexPath.row]) | ||
return cell | ||
} | ||
|
||
func tableView(_ tableView: UITableView, willDisplay cell: UITableViewCell, forRowAt indexPath: IndexPath) { | ||
let messages = sections[indexPath.section] | ||
let message = messages[indexPath.row] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Without this PR, you likely to get crash here because given indexPath is not "reversed", which does not match indexPath passed to |
||
print("willDisplay: \(message) at (section: \(indexPath.section), row: \(indexPath.row))") | ||
} | ||
} | ||
|
||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marty-suzuki
You can change
MessageModel
contents after merge, but please keepso it better demonstrates how the things work under the hood.