CMakeLists changes to fix macOS build: #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Check whether `CMAKE_CXX_COMPILER_ID` contains the string `Clang` rather than being exactly equal. This way it also matches `AppleClang`, which is what CMake uses for the default compiler on macOS; see also: https://cmake.org/cmake/help/latest/policy/CMP0025.html - Add `-Wno-sign-compare` to the special options for Flex-generated .c files, because Apple's Flex generates code that produces this warning by default. Compare to e.g.: vlm/asn1c#321
|
Thanks for the pull request! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check whether
CMAKE_CXX_COMPILER_IDcontains the stringClangrather than being exactly equal. This way it also matchesAppleClang, which is what CMake uses for the default compiler on macOS; see also:https://cmake.org/cmake/help/latest/policy/CMP0025.html
Add
-Wno-sign-compareto the special options for Flex-generated .c files, because Apple's Flex generates code that produces this warning by default. Compare to e.g.:Current master fails Travis CI on type comparison vlm/asn1c#321