♻️ Build URLs using URLComponents

mas-cli · May 6, 2021 · 585699d · 585699d
1 parent 88ce4f6
commit 585699d
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 40 deletions.
diff --git a/Sources/MasKit/Controllers/StoreSearch.swift b/Sources/MasKit/Controllers/StoreSearch.swift
@@ -73,35 +73,28 @@ extension StoreSearch {
     /// - Parameter appName: MAS app identifier.
     /// - Returns: URL for the search service or nil if appName can't be encoded.
     func searchURL(for appName: String) -> URL? {
-        guard let urlString = searchURLString(forApp: appName) else { return nil }
-        return URL(string: urlString)
-    }
-
-    /// Builds the search URL for an app.
-    ///
-    /// - Parameter appName: Name of app to find.
-    /// - Returns: String URL for the search service or nil if appName can't be encoded.
-    func searchURLString(forApp appName: String) -> String? {
-        if let urlEncodedAppName = appName.urlEncodedString {
-            return "https://itunes.apple.com/search?media=software&entity=macSoftware&term=\(urlEncodedAppName)"
+        guard var components = URLComponents(string: "https://itunes.apple.com/search") else {
+            return nil
         }
-        return nil
+
+        components.queryItems = [
+            URLQueryItem(name: "media", value: "software"),
+            URLQueryItem(name: "entity", value: "macSoftware"),
+            URLQueryItem(name: "term", value: appName),
+        ]
+        return components.url
     }
 
     /// Builds the lookup URL for an app.
     ///
     /// - Parameter appId: MAS app identifier.
     /// - Returns: URL for the lookup service or nil if appId can't be encoded.
     func lookupURL(forApp appId: Int) -> URL? {
-        guard let urlString = lookupURLString(forApp: appId) else { return nil }
-        return URL(string: urlString)
-    }
+        guard var components = URLComponents(string: "https://itunes.apple.com/lookup") else {
+            return nil
+        }
 
-    /// Builds the lookup URL for an app.
-    ///
-    /// - Parameter appId: MAS app identifier.
-    /// - Returns: String URL for the lookup service.
-    func lookupURLString(forApp appId: Int) -> String? {
-        "https://itunes.apple.com/lookup?id=\(appId)"
+        components.queryItems = [URLQueryItem(name: "id", value: "\(appId)")]
+        return components.url
     }
 }
diff --git a/Sources/MasKit/Extensions/String+PercentEncoding.swift b/Sources/MasKit/Extensions/String+PercentEncoding.swift
diff --git a/Tests/MasKitTests/Controllers/StoreSearchSpec.swift b/Tests/MasKitTests/Controllers/StoreSearchSpec.swift
@@ -28,20 +28,20 @@ class StoreSearchSpec: QuickSpec {
         describe("url string") {
             it("contains the app name") {
                 let appName = "myapp"
-                let urlString = storeSearch.searchURLString(forApp: appName)
+                let urlString = storeSearch.searchURL(for: appName)?.absoluteString
                 expect(urlString) == "https://itunes.apple.com/search?media=software&entity=macSoftware&term=\(appName)"
             }
             it("contains the encoded app name") {
                 let appName = "My App"
                 let appNameEncoded = "My%20App"
-                let urlString = storeSearch.searchURLString(forApp: appName)
+                let urlString = storeSearch.searchURL(for: appName)?.absoluteString
                 expect(urlString)
                     == "https://itunes.apple.com/search?media=software&entity=macSoftware&term=\(appNameEncoded)"
             }
             // Find a character that causes addingPercentEncoding(withAllowedCharacters to return nil
             xit("is nil when app name cannot be url encoded") {
                 let appName = "`~!@#$%^&*()_+ 💩"
-                let urlString = storeSearch.searchURLString(forApp: appName)
+                let urlString = storeSearch.searchURL(for: appName)?.absoluteString
                 expect(urlString).to(beNil())
             }
         }