Make sure operators ending in alphanumerics also have a word boundary after them #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
approved these changes
Feb 6, 2019
There was a problem hiding this comment.
I don't know if I get this right, but the error msgs constitute a great improvement. I really think that precise error msgs are important. And at least earlier, the error msgs (I know that this has not been a priority) was frustrating from time to time. I can't of course not say anything about the code quality :)
ghost
merged commit 
|
Thanks! Just to set the record straight, this PR introduces new parse errors here and there, but there are no new error messages or error types — agreed that the whole error message system needs an overhaul. Most likely this will be somewhat improved via #245 in the near future. |
masak
pushed a commit
to masak/007-conscious-risks
that referenced
this pull request
Feb 7, 2019
Thus `H25` becomes `H 25`, etc. This is necessary to track the change introduced in masak/alma#457 -- with this fix, the game works again.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ended up doing not just prefixes (as #408 discusses), but also infixes and postfixes, which suffer from the same problem.