addressed all comments

pyproject.toml

@@ -185,4 +185,5 @@ disable = [
   "missing-class-docstring",
   "missing-function-docstring",
   "cyclic-import",
-]
+]
+max-args = 10

src/banks/registries/directory.py

@@ -7,7 +7,7 @@
 from pydantic import BaseModel, Field
 
 from banks import Prompt
-from banks.registry import MetaNotFoundError, TemplateNotFoundError
+from banks.registry import TemplateNotFoundError
 
 # Constants
 DEFAULT_VERSION = "0"
@@ -49,22 +49,22 @@ def _scan(self):
             self._index.files.append(pf)
         self._index_path.write_text(self._index.model_dump_json())
 
-    def get_prompt(self, *, name: str, version: str | None = None) -> "Prompt":
-        version = version or DEFAULT_VERSION
+    def get(self, *, name: str, version: str = DEFAULT_VERSION) -> "PromptFile":
         for pf in self._index.files:
             if pf.name == name and pf.version == version and pf.path.exists():
-                return Prompt(pf.path.read_text())
+                return pf
         raise TemplateNotFoundError
 
+    def get_prompt(self, *, name: str, version: str = DEFAULT_VERSION) -> Prompt:
+        return Prompt(self.get(name=name, version=version).path.read_text())
+
     def _get_prompt_file(self, *, name: str, version: str) -> PromptFile | None:
         for pf in self._index.files:
             if pf.name == name and pf.version == version:
                 return pf
         return None
 
-    def _create_pf(  # pylint: disable=too-many-arguments
-        self, *, name: str, prompt: Prompt, version: str, overwrite: bool, meta: dict
-    ) -> "PromptFile":
+    def _create_pf(self, *, name: str, prompt: Prompt, version: str, overwrite: bool, meta: dict) -> "PromptFile":
         pf = self._get_prompt_file(name=name, version=version)
         if pf:
             if not overwrite:
@@ -78,32 +78,26 @@ def _create_pf(  # pylint: disable=too-many-arguments
         pf = PromptFile(name=name, version=version, path=new_prompt_file, meta=meta)
         return pf
 
-    def set(  # pylint: disable=too-many-arguments
+    def set(
         self,
         *,
         name: str,
         prompt: Prompt,
         meta: dict | None = None,
-        version: str | None = None,
+        version: str = DEFAULT_VERSION,
         overwrite: bool = False,
     ):
-        version = version or DEFAULT_VERSION
         meta = {**(meta or {}), "created_at": time.ctime()}
 
         pf = self._create_pf(name=name, prompt=prompt, version=version, overwrite=overwrite, meta=meta)
         if pf not in self._index.files:
             self._index.files.append(pf)
         self._index_path.write_text(self._index.model_dump_json())
 
-    def get_meta(self, *, name: str, version: str | None = None) -> dict:
-        version = version or DEFAULT_VERSION
-        for pf in self._index.files:
-            if pf.name == name and pf.version == version:
-                return pf.meta
-        raise MetaNotFoundError
+    def get_meta(self, *, name: str, version: str = DEFAULT_VERSION) -> dict:
+        return self.get(name=name, version=version).meta
 
-    def update_meta(self, *, meta: dict, name: str, version: str | None = None):
-        version = version or DEFAULT_VERSION
+    def update_meta(self, *, meta: dict, name: str, version: str = DEFAULT_VERSION):
         pf = self._get_prompt_file(name=name, version=version)
         if not pf:
             unk_err = f"Prompt {name}.{version} not found in the index. Cannot set meta for a non-existing prompt."

src/banks/registry.py

@@ -12,9 +12,6 @@ class TemplateNotFoundError(Exception): ...
 class InvalidTemplateError(Exception): ...
 
 
-class MetaNotFoundError(Exception): ...
-
-
 class TemplateRegistry(Protocol):
     def get(self, *, name: str, version: str | None = None) -> "Prompt": ...
 

tests/test_directory_registry.py

@@ -6,7 +6,7 @@
 
 from banks.prompt import Prompt
 from banks.registries.directory import DirectoryTemplateRegistry
-from banks.registry import MetaNotFoundError, TemplateNotFoundError
+from banks.registry import TemplateNotFoundError
 
 
 @pytest.fixture
@@ -23,6 +23,7 @@ def test_init_from_scratch(populated_dir):
     r = DirectoryTemplateRegistry(populated_dir)
     p = r.get_prompt(name="blog")
     assert p.raw.startswith("{# Zero-shot, this is already enough for most topics in english -#}")
+    assert r.get_meta(name="blog") == {}
 
 
 def test_init_from_existing_index(populated_dir):
@@ -41,6 +42,8 @@ def test_init_from_existing_index_force(populated_dir):
     r = DirectoryTemplateRegistry(populated_dir, force_reindex=True)
     with pytest.raises(TemplateNotFoundError):
         r.get_prompt(name="blog")
+    with pytest.raises(TemplateNotFoundError):
+        r.get(name="blog")
 
 
 def test_init_invalid_dir():
@@ -52,7 +55,7 @@ def test_get_not_found(populated_dir):
     r = DirectoryTemplateRegistry(populated_dir)
     with pytest.raises(TemplateNotFoundError):
         r.get_prompt(name="FOO")
-    with pytest.raises(MetaNotFoundError):
+    with pytest.raises(TemplateNotFoundError):
         r.get_meta(name="FOO")
 
 
@@ -69,7 +72,9 @@ def test_set_existing_overwrite(populated_dir):
     new_prompt = Prompt("a new prompt!")
     current_time = time.ctime()
     r.set(name="blog", prompt=new_prompt, overwrite=True)
+    assert r.get(name="blog").path.read_text() == "a new prompt!"
     assert r.get_prompt(name="blog").raw.startswith("a new prompt!")
+    assert r.get(name="blog").meta == {"created_at": current_time}
     assert r.get_meta(name="blog") == {"created_at": current_time}  # created_at changes because it's overwritten