[#149] 투표 완료 api 구현 #162
Merged
[#149] 투표 완료 api 구현 #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeonK1
approved these changes
Aug 7, 2024
|
@JeonK1 마자마자 그때 처음부터 다시 투표를 하자고 했던거 같아..! |
oreocube
approved these changes
Aug 7, 2024
Comment on lines
59
to
62
| VoteResultUiParam( | ||
| eventId = voteUiState.value.eventId, | ||
| voteResultIdList = ImmutableList(voteUiState.value.photoList.map { it.id }), | ||
| ).toDomainParam(), |
There was a problem hiding this comment.
이거 UiParam이라는게 나는 좀 어색한데 바로 도메인 모델 쓰는건 별로인가?
There was a problem hiding this comment.
오.. 다시 생각해보게 되는거 같아..! 지금 드는 생각은 진짜 리퀘스트용 모델이라서 뭔가 ui단에서 조작해서 쓸일이 없을거 같고 , 리퀘스트 할때 필드 형식에 맞춰서 보내줘야하니깐 ui용 리퀘스트 모델이 필요없을거 같다고 생각이 들긴하네..? 맞는 생각일까...?
There was a problem hiding this comment.
옹 내가 생각했던 방향도 비슷해 데이터 레이어에는 직렬화 어노테이션 붙이니까 따로 둬야하긴 하는데 프레젠테이션 에서는 그런건 없어서 도메인 바로 써도 되지않나~
| } | ||
|
|
||
| fun finishVote() { | ||
| // TODO: api 스펙 정의되면 리스트를 서버에 보내는 로직 구현하기 | ||
| viewModelScope.launch { | ||
| // TODO: 나중에 예외 처리 방법 결정되면 onSuccess,onFailure 구현하기 |
There was a problem hiding this comment.
onSuccess에서 투표 완료화면 이동하는거는 이 PR에서 추가되도 좋을듯@?
There was a problem hiding this comment.
아아아 오키오키 화면 이동 작업해 놓을게~~~
oreocube
reviewed
Aug 9, 2024
Comment on lines
8
to
15
| data class VoteResultResponse( | ||
| @Json(name = "event_id") | ||
| val eventId: Long, | ||
| ) |
JeonK1
reviewed
Aug 12, 2024
...ntation/src/main/java/com/mashup/gabbangzip/sharedalbum/presentation/ui/vote/VoteActivity.kt
Outdated
Show resolved
Hide resolved
...ntation/src/main/java/com/mashup/gabbangzip/sharedalbum/presentation/ui/vote/VoteActivity.kt
Show resolved
Hide resolved
...c/main/java/com/mashup/gabbangzip/sharedalbum/presentation/ui/vote/navigation/VoteNavHost.kt
Outdated
Show resolved
Hide resolved
SEO-J17
force-pushed
the
feature/#149-finish-vote-api
branch
from
9b3d790 to
ab5fb79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue No
Overview (Required)
Screenshot