Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#181] 그룹 관련 api path인자 수정 #182

Merged
merged 1 commit into from
Aug 15, 2024
Merged

[#181] 그룹 관련 api path인자 수정 #182

merged 1 commit into from
Aug 15, 2024

Conversation

SEO-J17
Copy link
Collaborator

@SEO-J17 SEO-J17 commented Aug 15, 2024

Issue No

Overview (Required)

  • 그룹 관련 api id -> groupId로 이름 변경했습니다~

Screenshot

@SEO-J17 SEO-J17 self-assigned this Aug 15, 2024
JeonK1
JeonK1 approved these changes Aug 15, 2024
View reviewed changes
Copy link
Collaborator

@JeonK1 JeonK1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

인자명이 바뀐거구나 이왕이면 일치시키는게 좋긴 하지~~
굳~~ 어푸할게!

oreocube
oreocube approved these changes Aug 15, 2024
View reviewed changes
Copy link
Member

@oreocube oreocube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

사실 나도 어제 보고 멈칫 하긴 했어서 맞추는거 좋은거같아~ 굳

@SEO-J17 SEO-J17 merged commit a587b01 into develop Aug 15, 2024
1 check passed
@SEO-J17 SEO-J17 deleted the feature/#181-group-api-path-parameter branch August 15, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeonK1 JeonK1 JeonK1 approved these changes

@oreocube oreocube oreocube approved these changes

@sooziini sooziini Awaiting requested review from sooziini sooziini is a code owner

Assignees

@SEO-J17 SEO-J17

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

그룹 관련 api path인자 수정
3 participants
@SEO-J17 @JeonK1 @oreocube