Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#159] 그룹 생성하기 완료 화면 내 링크 복사 버튼 잘림 #211

Merged
merged 9 commits into from
Aug 19, 2024
Merged

[#159] 그룹 생성하기 완료 화면 내 링크 복사 버튼 잘림 #211

merged 9 commits into from
Aug 19, 2024

Conversation

JeonK1
Copy link
Collaborator

@JeonK1 JeonK1 commented Aug 17, 2024

Issue No

Overview (Required)

  • 그룹 생성하기 완료 화면 내 링크 복사 버튼 잘림
  • 기타 화면들도 이런 상황에서 스크롤 될 수 있도록 처리 작업 진행
  • 그룹 생성관련 화면들 공통로직 GroupCreationScaffold 로 정리 후 적용

Screenshots

_2024_08_18_01_46_21_838.mp4

참고) 디바이스의 최소 width 를 조정해서 스크롤 상황이 발생할 수 있도록 강제하여 테스트했습니당

@JeonK1 JeonK1 self-assigned this Aug 17, 2024
sooziini
sooziini reviewed Aug 19, 2024
View reviewed changes
Copy link
Collaborator

@sooziini sooziini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

intro 제외하고 나머지 화면들을 scaffold로 묶었구나 멋져멋져 궁금한 점들을 남겨보았어 확인 함 부탁행.

...p/gabbangzip/sharedalbum/presentation/ui/groupcreation/keyword/GroupCreationKeywordScreen.kt Outdated Show resolved Hide resolved
.../mashup/gabbangzip/sharedalbum/presentation/ui/groupcreation/name/GroupCreationNameScreen.kt Show resolved Hide resolved
...p/gabbangzip/sharedalbum/presentation/ui/groupcreation/keyword/GroupCreationKeywordScreen.kt Show resolved Hide resolved
@sooziini sooziini self-requested a review August 19, 2024 13:42
sooziini
sooziini approved these changes Aug 19, 2024
View reviewed changes
Copy link
Collaborator

@sooziini sooziini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋당. 난 어푸~

oreocube
oreocube approved these changes Aug 19, 2024
View reviewed changes
Copy link
Member

@oreocube oreocube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니당

@JeonK1 JeonK1 merged commit 8a891e5 into develop Aug 19, 2024
1 check passed
@oreocube oreocube deleted the feature/#159-complete-scrollable branch August 19, 2024 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oreocube oreocube oreocube approved these changes

@sooziini sooziini sooziini approved these changes

@SEO-J17 SEO-J17 Awaiting requested review from SEO-J17 SEO-J17 is a code owner

Assignees

@JeonK1 JeonK1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

그룹 생성하기 완료 화면 내 링크 복사 버튼 잘림
3 participants
@JeonK1 @sooziini @oreocube