-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#199][#221] 그룹상세 이미지뷰어 연결 #222
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
a8c1a59
:sparkles: #199 이미지뷰어에 필요한 데이터 Serializable
oreocube 335ea43
:sparkles: #199 이미지뷰어 액티비티 추가
oreocube a728605
:sparkles: #199 이미지뷰어 화면 연결
oreocube 223d881
:sparkles: #199 statusbar 영역 색상 제어
oreocube 56e3819
:sparkles: #221 스플래시, 메인 statusbar 색상 제어
oreocube 99e3678
:sparkles: #221 statusbar 색상 제어
oreocube File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
49 changes: 49 additions & 0 deletions
49
...m/mashup/gabbangzip/sharedalbum/presentation/ui/main/groupdetail/HistoryDetailActivity.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,49 @@ | ||
package com.mashup.gabbangzip.sharedalbum.presentation.ui.main.groupdetail | ||
|
||
import android.content.Context | ||
import android.content.Intent | ||
import android.graphics.Color.TRANSPARENT | ||
import android.os.Bundle | ||
import androidx.activity.ComponentActivity | ||
import androidx.activity.SystemBarStyle | ||
import androidx.activity.compose.setContent | ||
import androidx.activity.enableEdgeToEdge | ||
import com.mashup.gabbangzip.sharedalbum.presentation.theme.SharedAlbumTheme | ||
import com.mashup.gabbangzip.sharedalbum.presentation.ui.model.GroupKeyword | ||
|
||
class HistoryDetailActivity : ComponentActivity() { | ||
private val state by lazy { intent.getSerializableExtra(KEY_HISTORY) as HistoryDetailState? } | ||
|
||
override fun onCreate(savedInstanceState: Bundle?) { | ||
super.onCreate(savedInstanceState) | ||
enableEdgeToEdge( | ||
statusBarStyle = SystemBarStyle.dark( | ||
TRANSPARENT, | ||
), | ||
) | ||
setContent { | ||
SharedAlbumTheme { | ||
state?.let { state -> | ||
HistoryDetailScreen( | ||
groupName = state.groupName, | ||
keyword = GroupKeyword.getKeyword(state.keyword), | ||
item = state.history, | ||
onClickBackButton = { finish() }, | ||
) | ||
} | ||
} | ||
} | ||
} | ||
|
||
companion object { | ||
private const val KEY_HISTORY = "history" | ||
|
||
fun openActivity(context: Context, state: HistoryDetailState) { | ||
context.startActivity( | ||
Intent(context, HistoryDetailActivity::class.java).apply { | ||
putExtra(KEY_HISTORY, state) | ||
}, | ||
) | ||
} | ||
} | ||
} |
10 changes: 10 additions & 0 deletions
10
.../com/mashup/gabbangzip/sharedalbum/presentation/ui/main/groupdetail/HistoryDetailState.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
package com.mashup.gabbangzip.sharedalbum.presentation.ui.main.groupdetail | ||
|
||
import com.mashup.gabbangzip.sharedalbum.presentation.ui.main.groupdetail.model.HistoryItem | ||
import java.io.Serializable | ||
|
||
data class HistoryDetailState( | ||
val groupName: String, | ||
val keyword: String, | ||
val history: HistoryItem, | ||
) : Serializable |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: 이거 디테일에서만 사용되는데 액티비티로 뺀 이유가 있을까?? 컴포저블로 하는건 별로일까..? 뭔가 뒤로가기도 있어서 컴포저블로 하는게 더 자연스러웠던거 같아서..! 스테이터스 바 땜에 그런건감..?