-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#286] 홈화면 태그 필터 추가 #293
[#286] 홈화면 태그 필터 추가 #293
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생했어~ 오빠 열일하네 요즘.
한 가지 궁금한 게 나는 태그에 해당하는 그룹이 없는 경우에는 그 태그를 안 보여주는 걸로 이해했었거둔 그래서 figma에 코멘트 남겨두었엉. 뭔가 모든 태그를 보여주게되면 해당하는 그룹이 없을 때는 empty 표시를 해준다는 등 뭔가 추가 처리가 필요할 거 같아서 말이지
presentation/src/main/java/com/mashup/gabbangzip/sharedalbum/presentation/ui/common/PicTag.kt
Show resolved
Hide resolved
...ain/java/com/mashup/gabbangzip/sharedalbum/presentation/ui/main/grouphome/GroupHomeScreen.kt
Show resolved
Hide resolved
...ain/java/com/mashup/gabbangzip/sharedalbum/presentation/ui/main/grouphome/GroupHomeScreen.kt
Outdated
Show resolved
Hide resolved
...ain/java/com/mashup/gabbangzip/sharedalbum/presentation/ui/main/grouphome/GroupHomeScreen.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
계원아 고생했어~~~ 늦은 리뷰 먄먄 ㅠㅠ 코멘트 몇개 달아놨어..! 요즘 작업 너무 열심히 하는거 아니야~? ㅋㄷㅋㄷ 멋져..!
...ain/java/com/mashup/gabbangzip/sharedalbum/presentation/ui/main/grouphome/GroupHomeScreen.kt
Outdated
Show resolved
Hide resolved
...a/com/mashup/gabbangzip/sharedalbum/presentation/ui/main/grouphome/model/FilterTagUiModel.kt
Outdated
Show resolved
Hide resolved
...ain/java/com/mashup/gabbangzip/sharedalbum/presentation/ui/main/grouphome/GroupHomeScreen.kt
Show resolved
Hide resolved
...ain/java/com/mashup/gabbangzip/sharedalbum/presentation/ui/main/grouphome/GroupHomeScreen.kt
Show resolved
Hide resolved
.../java/com/mashup/gabbangzip/sharedalbum/presentation/ui/main/grouphome/GroupHomeViewModel.kt
Show resolved
Hide resolved
import java.net.UnknownHostException | ||
import javax.inject.Inject | ||
|
||
@HiltViewModel | ||
class GroupHomeViewModel @Inject constructor( | ||
getGroupListUseCase: GetGroupListUseCase, | ||
) : ViewModel() { | ||
private val groupUiState = getGroupListUseCase() | ||
private val filterTagUiState: MutableStateFlow<List<FilterTagUiModel>> = MutableStateFlow( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이거 stateFlow로 따로 뺀 이유가 있엉?? groupUiState 안에 인자 추가로 처리해줄 수 있을거 같은데 따로 분리해서 combine한 이유가 있을까??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
엇 혹시 인자 추가 처리가 어떤건지 구체적으로 알 수 있을까..?!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
늦은 리뷰 미안..ㅎ.ㅎ 나 저거 dataclaas로 한줄 알았어..ㅎ 그리고 저 uiState가 flow였군..! ㅎ.. 잘못봤슴다 제가
.../java/com/mashup/gabbangzip/sharedalbum/presentation/ui/main/grouphome/GroupHomeViewModel.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
저는 좋습니다~ 다른 분들 코멘트 확인해주십셔
...a/com/mashup/gabbangzip/sharedalbum/presentation/ui/main/grouphome/model/FilterTagUiModel.kt
Outdated
Show resolved
Hide resolved
...ain/java/com/mashup/gabbangzip/sharedalbum/presentation/ui/main/grouphome/GroupHomeScreen.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아이 늦게 어푸해서 죄삼다~~~ 어푸 할게용! 계원이 고생했어~~
저 부분 코멘트 달렸는데 태그에 해당하는 그룹이 없을 때는 그 태그를 안 보여주게끔 해야 한다더라고! 일단 이 pr은 머지하고 이슈 따서 추가 작업하는걸루. |
@sooziini 대박... 물어봐줘서 고마워!! 이슈파서 따로 작업할게~~ |
Issue No
Overview (Required)
Links
Screenshot
_2024_09_03_22_50_20_434.mp4