[#297] 투표화면 에러 토스트 발생하는 버그 #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sooziini
reviewed
Sep 5, 2024
Comment on lines
57
to
+58
| LaunchedEffect(key1 = state.isError) { | ||
| coroutineScope.launch { | ||
| if (state.isError) { |
There was a problem hiding this comment.
궁금한 거. key가 state.isError인데 안에서 if문으로 한번더 체크를 해줘야 버그 없이 잘 뜨는건가 ..? 뭐가 다른건지 궁금해성
There was a problem hiding this comment.
내가 이해한거로는? LaunchedEffect의 key에 할당된 값이 변할때마다 실행되는 걸로 알고 있는데, true / false에 상관없이 이미 초기값이 false로 할당되니깐 그때 실행이 되는거 같아! Boolean값이 중요한게 아니라 key에 할당된 값이 변하는지 안변하는지가 중요한거라고 이해했엉. 그래서 초기에 값을 할당하니깐 뭔가 변화를 감지하고 실행한거 같아..!
oreocube
approved these changes
Sep 5, 2024
JeonK1
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue No
Overview (Required)
Screenshot
KakaoTalk_Video_2024-09-05-10-46-39.mp4