Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#299] 플로팅 버튼 클릭 시 나오는 배경화면 수정 #303

Merged
merged 3 commits into from
Sep 10, 2024
Merged

[#299] 플로팅 버튼 클릭 시 나오는 배경화면 수정 #303

merged 3 commits into from
Sep 10, 2024

Conversation

JeonK1
Copy link
Collaborator

@JeonK1 JeonK1 commented Sep 9, 2024

Issue No

Overview (Required)

  • 플로팅 버튼 클릭 시 나오는 배경화면 수정

Links

Screenshot

Before After

@JeonK1 JeonK1 self-assigned this Sep 9, 2024
SEO-J17
SEO-J17 approved these changes Sep 10, 2024
View reviewed changes
Copy link
Collaborator

@SEO-J17 SEO-J17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

쉐도우 나이스~~ 어푸할게~~ LGTM!

sooziini
sooziini approved these changes Sep 10, 2024
View reviewed changes
Copy link
Collaborator

@sooziini sooziini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굳.ㅎㅎ 근데 궁금해서 물어보는건데 shadow 5.dp라는 게 figma에 나와있어 지금..? 나만 안 보이는건가 해성

@JeonK1
Copy link
Collaborator Author

JeonK1 commented Sep 10, 2024

굳.ㅎㅎ 근데 궁금해서 물어보는건데 shadow 5.dp라는 게 figma에 나와있어 지금..? 나만 안 보이는건가 해성

@sooziini 아 이거..는.. shadow 를 딱히 dp 단위로 넣어주거나 그런거 없이 그냥 Effects - drop shadow 로 디자인이 되어있더라구? 그래서 눈대중으로 맞춰보았어! (요 부분까지 세세하게 요청하지는 않으려는 생각으로 작성했어..!)

@JeonK1 JeonK1 merged commit 3261193 into develop Sep 10, 2024
1 check passed
@JeonK1 JeonK1 deleted the feature/#299 branch September 20, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sooziini sooziini sooziini approved these changes

@SEO-J17 SEO-J17 SEO-J17 approved these changes

@oreocube oreocube Awaiting requested review from oreocube oreocube is a code owner

Assignees

@JeonK1 JeonK1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

플로팅 버튼 클릭 시 나오는 배경화면 수정
3 participants
@JeonK1 @sooziini @SEO-J17