Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#302] PicTag 공통로직으로 다시 모아주기 #310

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Conversation

JeonK1
Copy link
Collaborator

@JeonK1 JeonK1 commented Sep 10, 2024

Issue No

Overview (Required)

  • PicTag 공통화 로직으로 다시 모으기
  • PicTag 에 늘어나봐야 그렇게 인자가 많이 안늘어날 것 같아서, 같이 가져가는 식으로 다시 모아주었습니다
  • 확실히 사용처에서는 중복코드가 사라져서 깔끔해지긴 한 것 같긴한데, 더 좋은 아이디어가 보인다면 마음편히 의견 부탁드립니다~

@JeonK1 JeonK1 self-assigned this Sep 10, 2024
Copy link
Collaborator

@sooziini sooziini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오 난 요게 깔끔하고 좋은 거 같애.ㅎㅎ 고생했엉

Copy link
Member

@oreocube oreocube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

디폴트 파라미터 좋당

@JeonK1 JeonK1 merged commit 585be50 into develop Sep 13, 2024
1 check passed
@oreocube oreocube deleted the feature/#302 branch September 14, 2024 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PicTag 공통화 로직으로 다시 모으기
3 participants