Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#331] 온보딩 화면 #333

Merged
merged 8 commits into from
Oct 3, 2024
Merged

[#331] 온보딩 화면 #333

merged 8 commits into from
Oct 3, 2024

Conversation

JeonK1
Copy link
Collaborator

@JeonK1 JeonK1 commented Oct 2, 2024

Issue No

Overview (Required)

  • 온보딩 화면 로컬 DB 저장 및 가져오기
  • 온보딩 화면 구현

Links

Screenshot

2024-10-03.1.12.38.mov

@JeonK1 JeonK1 self-assigned this Oct 2, 2024
Copy link
Member

@oreocube oreocube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굳굳 사소한 코멘트 몇개 남겼는데 반영하지 않아도 무방합니다아

Copy link
Collaborator

@sooziini sooziini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생했어 오빠~ 온보딩 이미지 텍스트랑 밑에 버튼 텍스트랑 뭔가 선명도 차이가 나서 부자연스러운 느낌이 있네 아숩당.

import com.mashup.gabbangzip.sharedalbum.presentation.theme.Gray80

@Composable
fun HorizontalDotIndicator(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pic 공통 컴포넌트로 빼도 좋겠당.ㅎㅎ

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

반영완료! 4f1c30c

@JeonK1 JeonK1 merged commit c78dd20 into develop Oct 3, 2024
1 check passed
@SEO-J17 SEO-J17 deleted the feature/#331 branch October 3, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

온보딩 화면
3 participants