-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#331] 온보딩 화면 #333
[#331] 온보딩 화면 #333
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
굳굳 사소한 코멘트 몇개 남겼는데 반영하지 않아도 무방합니다아
...c/main/java/com/mashup/gabbangzip/sharedalbum/domain/usecase/config/GetIsFirstOpenUseCase.kt
Outdated
Show resolved
Hide resolved
domain/src/main/java/com/mashup/gabbangzip/sharedalbum/domain/repository/ConfigRepository.kt
Show resolved
Hide resolved
.../java/com/mashup/gabbangzip/sharedalbum/presentation/ui/onboarding/HorizontalDotIndicator.kt
Outdated
Show resolved
Hide resolved
.../java/com/mashup/gabbangzip/sharedalbum/presentation/ui/onboarding/HorizontalDotIndicator.kt
Outdated
Show resolved
Hide resolved
...main/java/com/mashup/gabbangzip/sharedalbum/presentation/ui/onboarding/OnboardingActivity.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생했어 오빠~ 온보딩 이미지 텍스트랑 밑에 버튼 텍스트랑 뭔가 선명도 차이가 나서 부자연스러운 느낌이 있네 아숩당.
import com.mashup.gabbangzip.sharedalbum.presentation.theme.Gray80 | ||
|
||
@Composable | ||
fun HorizontalDotIndicator( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pic 공통 컴포넌트로 빼도 좋겠당.ㅎㅎ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
반영완료! 4f1c30c
Issue No
Overview (Required)
Links
Screenshot
2024-10-03.1.12.38.mov