키워드 모아보기 모듈화 #280
Merged
키워드 모아보기 모듈화 #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaesungLeee
requested review from
EvergreenTree97,
hj1115hj and
ze-zeh
as code owners
|
발표때 작업한거라 실기기 테스트를 아직 안해봐서 확인해보고 request 할게용! |
ze-zeh
approved these changes
Oct 6, 2024
| @@ -4,14 +4,14 @@ import androidx.paging.PagingData | |||
| import kotlinx.coroutines.flow.Flow | |||
| import kotlinx.coroutines.flow.flowOf | |||
| import team.ppac.common.android.base.UiState | |||
| import team.ppac.search.detail.model.SearchResultUiModel | |||
| import team.ppac.domain.model.Meme | |||
There was a problem hiding this comment.
결국 우리 모두 domain의 모델로 귀결됐네...
There was a problem hiding this comment.
요고는 어쩔수없이 common android에서 공용으로 쓰기위해..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
작업 내역 (Required)
Review Point (Required)
관련 링크