fix(lemminx): split macOS targets #5944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In regards to mason-org#5922 and redhat-developer/vscode-xml#1001, the same issue also occurs on macOS with ARM64 chips. The error I get on ARM64 is: The current machine does not support all of the following CPU features that are required by the image: [CX8, CMOV, FXSR, MMX, SSE, SSE2, SSE3, SSSE3, SSE4_1, SSE4_2, POPCNT, LZCNT, AVX, AVX2, BMI1, BMI2, FMA]. Please rebuild the executable with an appropriate setting of the -march option. Splitting the targets and installing the correct artifact fixes this. I tested it locally. :)
* origin/main: (67 commits) bump(neocmakelsp): update to v0.7.3 (mason-org#6007) bump(neocmakelsp): update to v0.7.2 (mason-org#6005) bump(basedpyright): update to v1.12.5 (mason-org#6004) bump(prettier): update to v3.3.1 (mason-org#6006) chore: remove schema (mason-org#6003) bump(neocmakelsp): update to v0.7.1 (mason-org#5998) bump(bsl-language-server): update to v0.23.0 (mason-org#5997) bump(sorbet): update to v0.5.11414 (mason-org#5996) bump(sonarlint-language-server): update to v4.6.0 (mason-org#5968) bump(snyk-ls): update to v20240605 (mason-org#5999) bump(cobol-language-support): downgrade to v2.1.1 (mason-org#6001) ci: add names to jobs (mason-org#6000) bump(iferr): update to v0.0.0-20240122035601-9c3e2fbe4bd1 (mason-org#5550) bump(buf-language-server): update to v0.0.0-20240213221648-8e42e5e2e24f (mason-org#5548) bump(cobol-language-support): update to v2.1.2 (mason-org#5675) bump(json-to-struct): update to v0.0.0-20230613234638-1f65fffbfdbb (mason-org#5551) bump(harper-ls): update to v0.8.5 (mason-org#5742) bump(nilaway): update to v0.0.0-20240524204351-885be9df8ef4 (mason-org#5552) bump(autotools-language-server): update to v0.0.19 (mason-org#5847) ci: use new mason-org actions (mason-org#5995) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
In regards to #5922 and redhat-developer/vscode-xml#1001, the same issue also occurs on macOS with ARM64 chips. The error I get on ARM64 is:
The current machine does not support all of the following CPU features that are required by the image: [CX8, CMOV, FXSR, MMX, SSE, SSE2, SSE3, SSSE3, SSE4_1, SSE4_2, POPCNT, LZCNT, AVX, AVX2, BMI1, BMI2, FMA]. Please rebuild the executable with an appropriate setting of the -march option.
Splitting the targets and installing the correct artifact fixes this. I tested it locally. :)
Issue ticket number and link
Checklist before requesting a review
Screenshots