Deferred calls #4723
Draft
Deferred calls #4723
+6,234
−1,188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
move reset of addr stack after event_emit
remove reset of created_event_index move event_emit
damip
reviewed
Oct 29, 2024
| .storage_costs_constants | ||
| .ledger_cost_per_byte | ||
| .saturating_mul_u64(call.parameters.len() as u64); | ||
| context.transfer_coins(None, Some(call.sender_address), amount, false)?; |
There was a problem hiding this comment.
in what case does the "?" trigger in this case ?
damip
reviewed
Oct 29, 2024
| if call.cancelled { | ||
| Ok(result) | ||
| } else { | ||
| let deferred_call_execution = || { |
There was a problem hiding this comment.
maybe extract this to another function for better clarity
modship
commented
Oct 29, 2024
plouis01
reviewed
Oct 29, 2024
| /// deferred call min gas increment (1 nanomassa) | ||
| pub const DEFERRED_CALL_MIN_GAS_INCREMENT: u64 = 1; | ||
| /// deferred call max gas cost (10 nanomassa) | ||
| pub const DEFERRED_CALL_MIN_GAS_COST: u64 = 10; |
There was a problem hiding this comment.
Is this DEFERRED_CALL_MIN_GAS_COST or the MAX as written in the commented part?
There was a problem hiding this comment.
Is this DEFERRED_CALL_MIN_GAS_COST or the MAX as written in the commented part?
Hello @plouis01, indeed it is an error in the comment, I will update it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resync_checkflag