Fix async message updates and add unit test #4766
Open
+212
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leo-Besancon
approved these changes
Oct 22, 2024
damip
reviewed
Nov 4, 2024
| @@ -83,7 +83,9 @@ impl ActiveHistory { | |||
| return HistorySearchResult::Present(SetUpdateOrDelete::Set(msg)); | |||
| } | |||
| Some(SetUpdateOrDelete::Update(msg_update)) => { | |||
| current_updates.apply(msg_update.clone()); | |||
| let mut combined_message_update = msg_update.clone(); | |||
There was a problem hiding this comment.
I think current_updates does not need to be mut anymore
There was a problem hiding this comment.
I think it still does because of line 88 :)
damip
reviewed
Nov 4, 2024
| current_updates.apply(msg_update.clone()); | ||
| let mut combined_message_update = msg_update.clone(); | ||
| combined_message_update.apply(current_updates); | ||
| current_updates = combined_message_update; | ||
| } | ||
| Some(SetUpdateOrDelete::Delete) => return HistorySearchResult::Absent, |
There was a problem hiding this comment.
how about this ? if the current_updates actually creates an element while it was deleted before... can it happen?
There was a problem hiding this comment.
- If we Delete then Set, the latest Set is taken into account and we break before
- If we Delete then Update, I don't think it's possible. If it happens it's ok to return Absent in my mind, but it would be a bug no?
damip
reviewed
Nov 4, 2024
| @@ -287,7 +287,7 @@ impl SpeculativeAsyncPool { | |||
| } | |||
| Present(SetUpdateOrDelete::Update(msg_update)) => { | |||
| current_changes.entry(message_id).and_modify(|e| { | |||
| e.apply(msg_update.clone()); | |||
| *e = msg_update.clone(); | |||
There was a problem hiding this comment.
It did work before, but it technically applied the current_changes twice (the returned msg_update already took them into account, so we directly replace it)
|
@sydhds unless you think otherwise, I think we can merge this one :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.