Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NewSlotExecutionOutputs filters #4834

Draft
wants to merge 5 commits into
base: damir_keys_algo
Choose a base branch
from
Draft

NewSlotExecutionOutputs filters #4834

wants to merge 5 commits into from

Conversation

modship
Copy link
Member

@modship modship commented Jan 24, 2025

  • document all added functions
  • try in sandbox /simulation/labnet
    • if part of node-launch, checked using the resync_check flag
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

@modship modship linked an issue Jan 24, 2025 that may be closed by this pull request
Implement remaining filters on NewSlotExecutionOutputs #4443
Open
@modship modship added api Issues related to the API MAIN.2.6 p2 labels Jan 24, 2025
@modship modship changed the base branch from mainnet_2_3 to damir_keys_algo January 24, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api Issues related to the API MAIN.2.6 p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement remaining filters on NewSlotExecutionOutputs
1 participant
@modship