Accessibility for action buttons. #308
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…action button is active and the platform is ios. Focuses on top button when action button is active.
dlombardi
changed the title
arelstone
reviewed
Oct 25, 2019
| } | ||
| const reactTag = findNodeHandle(ref); | ||
|
|
||
| Platform.OS === 'android' ? UIManager.sendAccessibilityEvent( |
There was a problem hiding this comment.
You could use the isAndroid-method witch is imported on line line 19 instead of this
|
|
||
| const focusOnView = (ref) => { | ||
| if (!ref) { | ||
| console.warn('ref is null'); |
There was a problem hiding this comment.
If this console.warn should stay, witch I think it could. I think that the error message should be better then this.
| this.state = { | ||
| resetToken: props.resetToken, | ||
| active: props.active | ||
| active: props.active, |
There was a problem hiding this comment.
Yea I'm on #teamtrailingcomma ❤️
| } = this.props; | ||
|
|
||
| if (nextProps.resetToken !== resetToken) { | ||
| if (nextProps.active === false && active === true) { |
There was a problem hiding this comment.
Nitpick:
The === true and === false is redundant.
Suggested change
| if (nextProps.active === false && active === true) { | |
| if (!nextProps.active && active) { |
Also, personally i'm not a fan of nested if statements
| return `${acc} ${actionButton.props.accessibilityLabel}, `; | ||
| }, announceActionsLabel); | ||
|
|
||
| if (actionButtons.length && Platform.OS === 'ios') { |
There was a problem hiding this comment.
Nitpick:
Maybe you should add an isIOS-method to shared.js, that checks the that Platform.OS === 'ios', and use is here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Announces action button items when action button is active and the platform is ios. Focuses on top button when action button is active.