Fix: Allow dynamic height for text container in ActionButtonItem #383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix: Allow dynamic height for text container in ActionButtonItem Removed the fixed `height` property from the `textContainer` style in `ActionButtonItem.js`. This change allows the text container to dynamically adjust its height based on the content and padding provided via the `textContainerStyle` prop. Previously, the fixed height could lead to text truncation if the content exceeded the predefined height. Now, developers can control the vertical spacing and ensure full text visibility by adjusting padding.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Allow dynamic height for text container in ActionButtonItem
Removed the fixed
heightproperty from thetextContainerstyle inActionButtonItem.js.This change allows the text container to dynamically adjust its height based on the content and padding provided via the
textContainerStyleprop. Previously, the fixed height could lead to text truncation if the content exceeded the predefined height. Now, developers can control the vertical spacing and ensure full text visibility by adjusting padding.