feat: expose multiple constructors #52
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1 @@ | ||
| module.exports = require('./lib'); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,129 @@ | ||
| import readPkgUp from 'read-pkg-up'; | ||
| import ExternalModule from 'webpack/lib/ExternalModule'; | ||
| import resolvePkg from 'resolve-pkg'; | ||
|
|
||
| import getResolver from './get-resolver'; | ||
|
|
||
| export const pluginName = 'dynamic-cdn-webpack-plugin'; | ||
| const moduleRegex = /^((?:@[a-z0-9][\w-.]+\/)?[a-z0-9][\w-.]*)/; | ||
|
|
||
| const getEnvironment = mode => { | ||
| switch (mode) { | ||
| case 'none': | ||
| case 'development': | ||
| return 'development'; | ||
|
|
||
| default: | ||
| return 'production'; | ||
| } | ||
| }; | ||
|
|
||
| export default class DynamicCdnWebpackPlugin { | ||
| constructor({disable = false, env, exclude, only, verbose, resolver} = {}) { | ||
| if (exclude && only) { | ||
| throw new Error('You can\'t use \'exclude\' and \'only\' at the same time'); | ||
| } | ||
|
|
||
| this.disable = disable; | ||
| this.env = env; | ||
| this.exclude = exclude || []; | ||
| this.only = only || null; | ||
| this.verbose = verbose === true; | ||
| this.resolver = getResolver(resolver); | ||
|
|
||
| this.modulesFromCdn = {}; | ||
| } | ||
|
|
||
| apply(compiler) { | ||
| if (!this.disable) { | ||
| this.execute(compiler, {env: this.env || getEnvironment(compiler.options.mode)}); | ||
| } | ||
| this.output(compiler); | ||
| } | ||
|
|
||
| execute(compiler, {env}) { | ||
| compiler.hooks.normalModuleFactory.tap(pluginName, nmf => { | ||
| nmf.hooks.factory.tap(pluginName, factory => async (data, cb) => { | ||
| const modulePath = data.dependencies[0].request; | ||
| const contextPath = data.context; | ||
|
|
||
| const isModulePath = moduleRegex.test(modulePath); | ||
| if (!isModulePath) { | ||
| return factory(data, cb); | ||
| } | ||
|
|
||
| const varName = await this.addModule(contextPath, modulePath, {env}); | ||
|
|
||
| if (varName === false) { | ||
| factory(data, cb); | ||
| } else if (varName == null) { | ||
| cb(null); | ||
| } else { | ||
| cb(null, new ExternalModule(varName, 'var', modulePath)); | ||
| } | ||
| }); | ||
| }); | ||
| } | ||
|
|
||
| async addModule(contextPath, modulePath, {env}) { | ||
| const isModuleExcluded = this.exclude.includes(modulePath) || | ||
| (this.only && !this.only.includes(modulePath)); | ||
| if (isModuleExcluded) { | ||
| return false; | ||
| } | ||
|
|
||
| const moduleName = modulePath.match(moduleRegex)[1]; | ||
| const {pkg: {version, peerDependencies}} = await readPkgUp({cwd: resolvePkg(moduleName, {cwd: contextPath})}); | ||
|
|
||
| const isModuleAlreadyLoaded = Boolean(this.modulesFromCdn[modulePath]); | ||
| if (isModuleAlreadyLoaded) { | ||
| const isSameVersion = this.modulesFromCdn[modulePath].version === version; | ||
| if (isSameVersion) { | ||
| return this.modulesFromCdn[modulePath].var; | ||
| } | ||
|
|
||
| return false; | ||
| } | ||
|
|
||
| const cdnConfig = await this.resolver(modulePath, version, {env}); | ||
|
|
||
| if (cdnConfig == null) { | ||
| if (this.verbose) { | ||
| console.log(`❌ '${modulePath}' couldn't be found, please add it to https://github.com/mastilver/module-to-cdn/blob/master/modules.json`); | ||
| } | ||
| return false; | ||
| } | ||
|
|
||
| if (this.verbose) { | ||
| console.log(`✔️ '${cdnConfig.name}' will be served by ${cdnConfig.url}`); | ||
| } | ||
|
|
||
| if (peerDependencies) { | ||
| const arePeerDependenciesLoaded = (await Promise.all(Object.keys(peerDependencies).map(peerDependencyName => { | ||
| return this.addModule(contextPath, peerDependencyName, {env}); | ||
| }))) | ||
| .map(x => Boolean(x)) | ||
| .reduce((result, x) => result && x, true); | ||
|
|
||
| if (!arePeerDependenciesLoaded) { | ||
| return false; | ||
| } | ||
| } | ||
|
|
||
| this.modulesFromCdn[modulePath] = cdnConfig; | ||
|
|
||
| return cdnConfig.var; | ||
| } | ||
|
|
||
| output(compiler) { | ||
| compiler.hooks.afterCompile.tapAsync(pluginName, (compilation, cb) => { | ||
| for (const [name, cdnConfig] of Object.entries(this.modulesFromCdn)) { | ||
| compilation.addChunkInGroup(name); | ||
| const chunk = compilation.addChunk(name); | ||
| chunk.files.push(cdnConfig.url); | ||
| } | ||
|
|
||
| cb(); | ||
| }); | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| // eslint-disable-next-line no-unused-vars | ||
| import HtmlWebpackPlugin from 'html-webpack-plugin'; | ||
| import HtmlWebpackIncludeAssetsPlugin from 'html-webpack-include-assets-plugin'; | ||
|
|
||
| import DynamicCdnWebpackPlugin, {pluginName} from './dynamic-cdn-webpack-plugin'; | ||
|
|
||
| export default class HtmlDynamicCdnWebpackPlugin extends DynamicCdnWebpackPlugin { | ||
|
There was a problem hiding this comment. Nit: I feel there is no need to export this as |
||
| output(compiler) { | ||
| const includeAssetsPlugin = new HtmlWebpackIncludeAssetsPlugin({ | ||
| assets: [], | ||
| publicPath: '', | ||
| append: false | ||
| }); | ||
|
|
||
| includeAssetsPlugin.apply(compiler); | ||
|
|
||
| compiler.hooks.afterCompile.tapAsync(pluginName, (compilation, cb) => { | ||
| const assets = Object.values(this.modulesFromCdn).map( | ||
| moduleFromCdn => moduleFromCdn.url | ||
| ); | ||
|
|
||
| // HACK: Calling the constructor directly is not recomended | ||
| // But that's the only secure way to edit `assets` afterhand | ||
| includeAssetsPlugin.constructor({ | ||
| assets, | ||
| publicPath: '', | ||
| append: false | ||
| }); | ||
|
|
||
| cb(); | ||
| }); | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,169 +1,2 @@ | ||
| export {default as HtmlDynamicCdnWebpackPlugin} from './html-dynamic-cdn-webpack-plugin'; | ||
|
There was a problem hiding this comment. Once we remove the |
||
| export {default as DynamicCdnWebpackPlugin} from './dynamic-cdn-webpack-plugin'; | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same thing about
defaultexports