Fix dendrogram view #127
Merged
Fix dendrogram view #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… instance * Remove the listeners from the components on close() * Reasoning: before this commit, if the user had closed the JFrame, the instance of it was still kept, since the DendrogramView object was never cleaned up. Thus, also the listeners were still unnecessarily active, which lead to bugs in certain situations
* Without this, the clustering may lead to wrong results, since it operates on a branch graph that potentially is outdated.
stefanhahmann
force-pushed
the
fix-dendrogram-view
branch
from
42228d7 to
32d8d5d
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes bugs that could occur, if multiple DendrogramViews have been opened by the user.
If they were closed, they were not actually garbage collected and listeners were still active leading to bugs in some situations.