Fix fit ellipsoid test #12
Conversation
…Data and a SelectionModel * The reasoning behind this new class is to achieve testability of the FitEllipsoidPlugin in a headless way / in a non-graphics supported environment
* This is to allow the class to be used for graphical and non-graphical applications.
stefanhahmann
force-pushed
the
fix-fit-ellipsoid-test
branch
from
274b6ae to
5f29d5b
Compare
…efactor HeadlessProjectModel to DefaultMinimalProjectModel * Add javadoc for MinimalProjectModel and DefaultMinimalProjectModel
stefanhahmann
force-pushed
the
fix-fit-ellipsoid-test
branch
from
7da1205 to
5d2bebe
Compare
There was a problem hiding this comment.
This PR fixes the FitEllipsoidPluginTest by using an UI independent MinimalProjectModel for testing.
The new name MinimalProjectModel is I think less confusing than the first idea: HeadlessProjectModel. 👍
Splitting a class into implementation and interface is often a good idea. But I don't think we need it here. (The MinimalProjectModel is for now only meant for testing not part of a plugin API.) Please remove the interface and rename the DefaultMinimalProjectModel to MinimalProjectModel.
src/main/java/org/mastodon/mamut/fitting/FitEllipsoidPlugin.java
Outdated
Show resolved
Hide resolved
…lProjectModel to MinimalProjectModel. * Splitting into implementation and interface is not needed here. (The MinimalProjectModel is for now only meant for testing not part of a plugin API.)
stefanhahmann
force-pushed
the
fix-fit-ellipsoid-test
branch
from
19659e8 to
2b03a0d
Compare
Agreed and Done. |
|
@tinevez do you think this could be merged? this would fix the currently failing ci. |
…class ArtificialData
Due to changes in https://github.com/mastodon-sc/mastodon the FitEllipsoidTest was failing on GitHub.
The reason is that the ProjectModel that the test uses instantiates the WindowManager, which instantiates a PreferenceDialog. This would need a graphical environment, which is not present in the Github CI environment.
A workaround for this is a newly introduced class MinimalProjectModel, which is used in the FitEllipsoidPlugin and in the FitEllipsoidPluginTest