Add import of tags, radius and links to CSV importer #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arsing * In some datasets, number format exceptions may occur if leading trailing whitespaces are not trimmed before parsing the number value
* By doing so startImport() can be called before the import of potentially huge amount of spots starts * startImport() pauses some listeners so that undo/redo functionality does not cause problems during mass import * finishImport resumes these listeners
* A column mother id would allow to import links between subsequent spots during the CSV import
* By this the Autocloseable feature of the CSVReader is used
* If a radius column is specified the default radius would be overwritten with a radius found in this column
* e.g. in the table the name of a spot is called "label"
stefanhahmann
force-pushed
the
add-mother-id-column
branch
from
1d3f791 to
39892c9
Compare
stefanhahmann
force-pushed
the
add-mother-id-column
branch
from
39892c9 to
b4165ca
Compare
* The reason for this change is that the initial assumption that spots would be sorted by the time frame did not hold true for some test data sets * In a test data set, it happened that the child spot was in the file before the parent spot so that the parent spot could not be found
|
Resolves #15 |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull request adds some extensions to the current CSV importer.
It adds 3 additional features that can be imported using it
In order to maintain usability, while the dialog is growing two new sections are introduced:
The PR also contains some technical (hopefully) improvements:
The dialog would look like this if this PR is accepted:
Unit tests: