Shuffling menu items inside the Plugins submenu #6
Conversation
TWEAK_DATASET_PATH_KEYS moved always to the end of the blocks because it is now part of the File menu entry, not Plugins
file with the all remaining plugins in this repository
xulman
force-pushed
the
shuffling_plugins_menu
branch
from
e101cf0 to
33cf326
Compare
|
thus far, I have mostly only massaged menu item names, their descriptions and cosmetics of this kind |
|
yeah, that was one more forgotten cosmetics now, I will add commits to move a few files around to arrange and prepare the layout for another PR in which I'd like to add a few more relevant plugins |
|
I would stop the PR here, and kindly ask @maarzt to review and consider for merging |
|
|
|
haha, this is actually screen shot of a code compiled in part against old code.. and so menu items are Failing the Naming Convention... but in reality, all is fixed, just the photo is wrong |
| private static final String EXPORT_PHYLOXML = "[exports] export phyloxml for selection"; | ||
| private static final String FLIP_DESCENDANTS = "[trees] flip descendants"; | ||
| private static final String COPY_TAG = "copy tag"; | ||
| private static final String INTERPOLATE_SPOTS = "[trees] interpolate missing spots"; | ||
| private static final String LABEL_SELECTED_SPOTS = "[trees] label selected spots"; | ||
| private static final String COMPACT_LINEAGE_VIEW = "[displays] show compact lineage"; | ||
| private static final String SORT_TREE = "[trees] sort lineage tree"; | ||
| private static final String MERGE_PROJECTS = "merge projects"; | ||
| private static final String TWEAK_DATASET_PATH = "fix project image path"; |
There was a problem hiding this comment.
I have no strong opinion here, but maybe let's keep the "[tomancak] ..." prefix here. It's more consistent, and gives an indication in the settings dialog that this plugin belongs to mastodon-tomancak.
There was a problem hiding this comment.
okay, changed that back to [tomancak]... I also don't have a strong opinion on that
the original idea was to be able to group/filter related activities with a single keyword.. and so was essentially mirroring the menu layout in the brackets (besides, now that this repo is among the default installed, user is probably not realizing/not cares (maybe?)/does not see the source of this functionality)
but words like lineage, spot, sort... tend to group reasonably well and a user can see everything relevant and adjust/overview shortcuts in the key bindings dialog... so my primary goal is preserved and thus I'm happy :-)
I've took care of it in the commit dde59b7
|
|
||
| private static final String[] EXPORT_PHYLOXML_KEYS = { "not mapped" }; | ||
| private static final String[] FLIP_DESCENDANTS_KEYS = { "not mapped" }; | ||
| private static final String[] COPY_TAG_KEYS = { "not mapped" }; | ||
| private static final String[] INTERPOLATE_SPOTS_KEYS = { "not mapped" }; | ||
| private static final String[] TWEAK_DATASET_PATH_KEYS = { "not mapped" }; | ||
| private static final String[] LABEL_SELECTED_SPOTS_KEYS = { "not mapped" }; |
There was a problem hiding this comment.
F2 would be nice as a key combination for renaming spots.
There was a problem hiding this comment.
very cool idea... -> commit 7d2b553
made sure that grouping by keywords could work, that items include common keywords
|
thanks @maarzt for the feedback, I hope I managed to reflect them in the last two commits... and will now merge |
as a consequence to