Focus the created Spot of AddSpotAndLinkIt behaviour directly, when it is created #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… after it has been * The reasoning behind this change is that the OverlayGraphRenderer would recognize the newly created spot as existing, but yet invisible because the TrackOfFocusedVisibility would tell so, but this is actually not true.
tinevez
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to find the reason for #295.
I found a potential solution. With the changes of this PR the described bug cannot be reproduced anymore.
Big disclaimer: I am quite unsure about potential side effects of this change.
Also:
mastodon/src/main/java/org/mastodon/views/bdv/overlay/EditSpecialBehaviours.java
Line 525 in 373a2a9