Branch features disappear on project opening #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Includes a test, if branch features disappeared by just opening the a track scheme branch view
|
@tinevez I am not sure, if this PR would contradict what you had in mind earlier, when you introduced the strategy to frequently update the branch graph to have it up-to-date in as many situations as possible? |
stefanhahmann
force-pushed
the
branch-features-disappear-on-project-opening
branch
from
a715467 to
de4832d
Compare
… graph is up-to-date, when it is created * Only actually run the sync() method, if it has been informed that the branch graph is not up-to-date anymore before
* With the old 1gb setting the CI sometimes resulted in OutOfMemory Errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request changes behavior of the
BranchGraphSynchronizer.The
BranchGraphSynchronizeris set to optimistically assume that the branch graph isup-to-date = trueat the time the synchronizer is created. Thesync()method evaluates theup-to-dateflag and only performs the rebuilt, if theup-to-dateflag is set tofalse, which is usually the case, after the notifiers have informed the synchronizer that the graph had been changed.By this change, it can be achieved that, the branch features are not reset/lost after saving and re-opening a project or by just opening a track scheme branch view.
This Pull Request adds some unit tests to test the indented behavior:
testBranchFeaturesAfterSaveAndReloadinProjectLoaderTesttests, if previously computed branch feature still exist, if the project has only been saved and reloadedtestBranchFeaturesAfterOpeningBranchViewinMamutBranchViewTrackSchemeTesttests, if previously computed branch features still exist, after a TrackSchemeBranchView window was openedtestKeepBranchFeaturesAfterSyncWithoutChangesinBranchGraphSynchronizerTesttests, if previously computed branch features still exist, after thesync()method ofBranchGraphSynchronizerwas called without any previously notified changes to the graphtestKeepBranchFeaturesAfterSyncWithChangesinBranchGraphSynchronizerTesttests, if previously computed branch features still exist, after thesync()method ofBranchGraphSynchronizerwas called with previously notified changes to the graph. Since this is a current known issue, this test is ignored.Resolves #279