Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More complete restore of grapher gui state #344

Conversation

stefanhahmann
Copy link
Collaborator

This PR makes the following changes:

  • Only zoom out to full data extent in Grapher after Button "Plot" has been pressed
  • In cases, when the grapher is redrawn after changes, the screen transform will stay the same. This includes cases, when the Grapher is redrawn after opening a project
  • Add serialization of the GUI state of the grapher views. The following things are restored additionally the window size+position:
    • Selected X-Axis Feature + Projection
    • Selected Y-Axis Feature + Projection
    • The ScreenTransform that was used during saving the project
    • Whether or not to connect edges

The context chosen by the user can unfortunately not be restored, since the BDV View Windows have no unique ID. However, this is consistent to other views (e.g. TrackScheme), where the context can also not be restored.

grafik

…been pressed

* In cases, when the grapher is redrawn after changes, the screen transform will stay the same.
…atureSpecKey and FeatureProjectionSpec for a given projectionKey
…wGrapher and MamutViewGrapher implements them

* The required method getFrame() actually existed already in both classes so that no new implementation is required.
The following things are restored additionally the window size+position
* Selected X-Axis Feature + Projection
* Selected Y-Axis Feature + Projection
* The ScreenTransform that was used during saving the project
* Whether or not to connect edges

The context chosen by the user can unfortunately not be restored, since the BDV View Windows have no unique ID. However, this is consistent to other views (e.g. TrackScheme), where the context can also not be restored.
@stefanhahmann stefanhahmann self-assigned this Nov 7, 2024
@stefanhahmann stefanhahmann requested a review from tinevez November 7, 2024 13:39
Copy link
Contributor

@tinevez tinevez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested live, and checked syntax and conventions.

@tinevez
Copy link
Contributor

tinevez commented Nov 7, 2024

Awesome work.

@tinevez tinevez merged commit e722e4d into mastodon-sc:dev Nov 7, 2024
1 check passed
@stefanhahmann stefanhahmann deleted the more-complete-restore-of-grapher-gui-state branch November 8, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants