Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding science to JoinMastodon #259

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Adding science to JoinMastodon #259

wants to merge 5 commits into from

Conversation

chuckn408
Copy link

No description provided.

@vercel
Copy link

vercel bot commented Nov 22, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
joinmastodon ✅ Ready (Inspect) Visit Preview Nov 22, 2022 at 7:17PM (UTC)

This was referenced Jan 3, 2023
Open
Open
@ThisIsMissEm
Copy link
Contributor

I'd probably suggest splitting this PR in two: one to add the category, another to add your testimonial, as that's something different and may have different requirements for acceptance, however, I do note that currently there are no servers under the science category: https://api.joinmastodon.org/servers?category=science

@chuckn408 chuckn408 marked this pull request as draft April 30, 2024 20:13
@chuckn408 chuckn408 marked this pull request as ready for review April 30, 2024 20:18
@chuckn408
Copy link
Author

I took out the testimonial as suggested.

ThisIsMissEm
ThisIsMissEm reviewed Apr 30, 2024
View reviewed changes
public/testimonials/avatar_biomedmax.jpg Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should be removed on this branch

@chuckn408 chuckn408 marked this pull request as draft April 30, 2024 20:37
@chuckn408 chuckn408 marked this pull request as ready for review April 30, 2024 20:39
@chuckn408
Copy link
Author

Deleted per request @ThisIsMissEm

@ThisIsMissEm
Copy link
Contributor

@chuckn408 just to quote from #286, there's a bit more that'll need to happen for this to merge:

It’s not that simple, I need to add them server side and then sort servers into them.

So this may be waiting a while for merge, now that from what you can do it's good to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThisIsMissEm ThisIsMissEm ThisIsMissEm left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chuckn408 @ThisIsMissEm